GNU nano - Bugs: bug #54478, redoing any COUPLE_BEGIN/END...
You are not allowed to post comments on this tracker with your current authentication level.
bug #54478: redoing any COUPLE_BEGIN/END operation sets totsize to an invalid value
Submitter: | David Lawrence Ramsey <dolorous> | ||
Submitted: | Thu 09 Aug 2018 01:55:03 AM UTC | ||
Severity: | 3 - Normal | Status: | Fixed |
Assigned to: | dolorous | Open/Closed: | Closed |
Jump to the original submission
Mon 10 Sep 2018 05:51:03 PM UTC, comment #7: |
Benno Schulenberg <bens> |
Sat 11 Aug 2018 08:12:57 AM UTC, comment #6: Thanks for reporting and fixing this. The fix looks like the perfect solution. Pushed to master, commit fd65f744. |
Benno Schulenberg <bens> |
Thu 09 Aug 2018 06:12:36 AM UTC, comment #5: Took a stab at fixing it. The patch is attached. |
David Lawrence Ramsey <dolorous> |
Thu 09 Aug 2018 03:55:39 AM UTC, comment #4: Forgot to update the mail notification again; fixed now. |
David Lawrence Ramsey <dolorous> |
Thu 09 Aug 2018 03:53:14 AM UTC, comment #3: After tracing nano's undo and redo functions through gdb, when using COUPLE_BEGIN and COUPLE_END, in the undo struct, undo->newsize is never set to anything. And do_redo() unconditionally assigns openfile->totsize the value of undo->newsize, so openfile->totsize is thus set to an uninitialized value.
|
David Lawrence Ramsey <dolorous> |
Thu 09 Aug 2018 03:23:25 AM UTC, comment #2: (The second steps 2 and 3 in comment #1 should be 5 and 6.)
|
David Lawrence Ramsey <dolorous> |
Thu 09 Aug 2018 03:01:19 AM UTC, comment #1: A similar problem also occurs when running marked text through the alternate spell checker. This can be reproduced as follows:
|
David Lawrence Ramsey <dolorous> |
Thu 09 Aug 2018 01:55:03 AM UTC, original submission:
Currently, as of git 94b4f07, running an entire file through the alternate spell checker, and then undoing the spell check, sets the value of totsize to something completely out of range. This can be reproduced as follows, assuming the system has aspell installed, and using the attached file spell-test.txt:
|
David Lawrence Ramsey <dolorous> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 8 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-09-10 | bens | Open/Closed | Open | Closed | |
2018-08-11 | bens | Summary | undoing/redoing any COUPLE_BEGIN/COUPLE_END operation sets totsize to invalid value | redoing any COUPLE_BEGIN/END operation sets totsize to an invalid value | |
2018-08-11 | bens | Status | None | Fixed | |
Assigned to | None | dolorous | |||
2018-08-09 | dolorous | Attached File | - | Added 0001-undo-in-the-undo-struct-ensure-newsize-is-initialize.patch, #44750 | |
2018-08-09 | dolorous | Carbon-Copy | - | Added bens | |
2018-08-09 | dolorous | Summary | undoing/redoing alternate spell-check sets totsize to out-of-range value | undoing/redoing any COUPLE_BEGIN/COUPLE_END operation sets totsize to invalid value | |
2018-08-09 | dolorous | Attached File | - | Added spell-test.txt, #44748 |
Powered by Savane 3.13-bb6a.
Corresponding source code
Released in 3.0.