bugmake - Bugs: bug #54395, Regression in validation of...

 
 

bug #54395: Regression in validation of GNU-style long names in archives

Submitted by:  None
Submitted on:  Fri 27 Jul 2018 03:37:03 PM UTC  
 
Severity:  3 - Normal Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  Paul D. Smith <psmith> Open/Closed:  Closed
Component Version:  4.3 Operating System:  None
Fixed Release:  4.3 Triage Status:  Small Effort

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 04 Aug 2018 09:04:09 PM UTC, comment #3: 

Thanks Ben; applied with a minor tweak, plus added a regression test.  I decided this could go in under "fair use" because it doesn't modify too many lines so no need for copyright assignment for this.

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Sat 28 Jul 2018 10:00:53 AM UTC, comment #2: 

Philipp Wolski reported that the updated patch also works for the real project he's building.

Ben Hutchings <bwh>
Sat 28 Jul 2018 02:43:54 AM UTC, comment #1: 

A better example, which shows that my initial patch was still not correct:

# Both member names > 16 characters long
default: foo.a(looooooooooooong1) foo.a(looooooooooooong2)

(%): %
        ar rU $@ $%

looooooooooooong%:
        touch $@

Attaching a new patch that makes this work too.

(file #44643)

Anonymous
Fri 27 Jul 2018 03:37:03 PM UTC, original submission:  

Philipp Wolski <philipp.wolski@kisters.de> reported in https://bugs.debian.org/904749 that make sometimes fails to see archive members.

A simple example is:

# BEGIN
default: foo.a(looooooooooooong)

(%): %
ar rU $@ $%

looooooooooooong:
touch $@
# END

make will always want to remake the archive member because ar_scan() doesn't consider its name to be valid.

I've attached a patch that fixes this example; I will ask Philip to test it as well.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by bwh (Debian BTS)
  • -email is unavailable- added by bwh (Posted a comment)
  • -email is unavailable- added by bwh (add myself (actual submitter))
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-08-04 psmith StatusNone => Fixed
        Assigned toNone => psmith
        Open/ClosedOpen => Closed
        Fixed ReleaseNone => 4.3
        Triage StatusNone => Small Effort
    2018-07-28 bwh Carbon-Copy- => Added 904749-forwarded@bugs.debian.org
    2018-07-28 bwh Carbon-Copy- => Added bwh
    2018-07-28 None Attached File- => Added 0001-Fix-validation-of-long-names-in-archives.patch, #44643
    2018-07-27 None Attached File- => Added 0001-Fix-validation-of-GNU-style-long-names-in-archives.patch, #44639

    Back to the top


    Powered by Savane 3.7