bugmake - Bugs: bug #53465, Outdated GNU glob handles d_type...

 
 

bug #53465: Outdated GNU glob handles d_type incorrectly for GLOB_ONLYDIR

Submitted by:  Rich Felker <dalias>
Submitted on:  Sun 25 Mar 2018 05:11:34 PM UTC  
 
Severity:  3 - Normal Item Group:  Bug
Status:  Fixed Privacy:  Public
Assigned to:  Paul D. Smith <psmith> Open/Closed:  Closed
Component Version:  4.2.1 Operating System:  Any
Fixed Release:  4.3 Triage Status:  Small Effort

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 04 Aug 2018 06:30:23 PM UTC, comment #1: 

Thanks; fixed.

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Sun 25 Mar 2018 05:11:34 PM UTC, original submission:  

The code in GNU glob that handles GLOB_ONLYDIR when d_type is available fails to account for symlinks (DT_LNK) and thereby breaks glob expansion (e.g. $(wildcard ...), maybe other cases) in the case where non-final path components are symlinks.

This issue affects musl libc now that its public headers define _DIRENT_HAVE_D_TYPE, and any other implementation defining _DIRENT_HAVE_D_TYPE where gnulib decides to replace the system glob with the GNU glob that GNU make ships. It was originally reported on the musl mailing list:

http://www.openwall.com/lists/musl/2018/03/13/1

Upstream GNU glob fixed this issue a long time ago by adding a check for DT_LNK, but the fix was not incorporated into make's copy.

Rich Felker <dalias>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by psmith (Posted a comment)
  • -email is unavailable- added by dalias (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-08-04 psmith StatusNone => Fixed
        Assigned toNone => psmith
        Open/ClosedOpen => Closed
        Fixed ReleaseNone => 4.3
        Triage StatusNone => Small Effort

    Back to the top


    Powered by Savane 3.7