bugGNU troff - Bugs: bug #53052, [PATCH] manuals: Use correct...

 
 

bug #53052: [PATCH] manuals: Use correct macro, "BR" or "B" in a macro ("esc" and "EnvVar")

Submitted by:  Bjarni Ingi Gislason <bjarniig>
Submitted on:  Fri 02 Feb 2018 10:44:29 PM UTC  
 
Category:  None Severity:  1 - Wish
Item Group:  Documentation Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Open Planned Release:  None

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 04 Mar 2018 12:36:10 AM UTC, comment #2: 

  There is nothing wrong with the content of the patch.
It is based on and uses more knowledge than the current code.
It is thus superior to the current code.

  There is no data to support your claims.  Should people simply accept
that as true, without any facts or references?

  Is that a good best current practice?  What about the future?

  Is this project based on or accepts non-science?

  Is the policy: if not wrong(?), it may (shall) not be made better?

###

Herman Rubin in the Usenet forum "misc.education":

In the sciences, authority counts for little.  Quoting
Newton will not avail, unless he was correct in that
instance.  He was not always correct.

###

>I know people who can pass tests and get full scholarships to college
>who make bad decisions.  I don't think the ability to puke information
>onto a bubble sheet is going to help a person make a decision.


I agree.  Making decisions requires thinking, and this is not
developed my memorization and routine manipulations.  What is
needed is getting general principles, and having to decide when
and how to apply them in situations other than those in class
or in the textbooks.

We have far too many bureaucrats in decision making positions
who can only go by the book, or try to impose a "moral" version
which is certainly not within their authority.

Bjarni Ingi Gislason <bjarniig>
Fri 16 Feb 2018 11:13:33 PM UTC, comment #1: 

This should be rejected.  There is nothing wrong with the code Bjarni suggests to change, except that in general, manual pages ought to refrain from using the .de request.

Ingo Schwarze <schwarze>
Project Member
Fri 02 Feb 2018 10:44:29 PM UTC, original submission:  

From 8238a9202a42d8d8134552c75b1186b1228f8e9d Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Fri, 2 Feb 2018 22:34:34 +0000
Subject: [PATCH] manuals: Use correct macro, "BR" or "B" in a macro ("esc" and
"EnvVar")

groff.1.man:
  Additionally correct ".BR X" to ".B X"

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
man/groff.7.man            | 7 ++++++-
src/roff/groff/groff.1.man | 9 +++++++--
2 files changed, 13 insertions(+), 3 deletions(-)

diff --git a/man/groff.7.man b/man/groff.7.man
index 84a3de2d..18e1dd77 100644
--- a/man/groff.7.man
+++ b/man/groff.7.man
@@ -161,7 +161,12 @@ groff \- a short reference for the GNU roff language
.\" Result  : prints \name, where 'name' is in B, 'punct' in R
.\"
.de esc
-.  BR "\e\\$1" \\$2
+.  ie \\n[.$]<2 \{\
+.    B "\e\\$1"
+.  \}
+.  el \{\
+.    BR "\e\\$1" \\$2
+.  \}
..
.\" ====================================================================
.\" .escarg name arg [punct]
diff --git a/src/roff/groff/groff.1.man b/src/roff/groff/groff.1.man
index 16a2c262..6cc076c3 100644
--- a/src/roff/groff/groff.1.man
+++ b/src/roff/groff/groff.1.man
@@ -40,7 +40,12 @@ groff \- front-end for the groff document formatting system
.\" Environment variable
.de EnvVar
.  SM
-.  BR \%\\$1 \\$2
+.  ie \n[.$]<2 \{\
+.    B \%\\$1
+.  \}
+.  el \{\
+.    BR \%\\$1 \\$2
+.  \}
..
.\" ====================================================================
.\" 'char or string'
@@ -809,7 +814,7 @@ The
.I physical
paper size, giving the actual dimensions of the paper sheets, is
controlled by output devices like
-.BR grops
+.B grops
with the command-line options
.B \-p
and
--
2.15.1

Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by schwarze (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-02-16 schwarze Severity3 - Normal => 1 - Wish

    Back to the top


    Powered by Savane 3.5