bugGNU roff - Bugs: bug #52990, [ms] update warning manipulation...

 
 

bug #52990: [ms] update warning manipulation to use newer troff default

Submitter:  Bjarni Ingi Gislason <bjarniig>
Submitted:  Sun 28 Jan 2018 02:55:40 PM UTC
   
 
Category:  Macro ms Severity:  2 - Minor
Item Group:  Incorrect behaviour Status:  Invalid
Privacy:  Public Assigned to:  gbranden
Open/Closed:  Closed Planned Release:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 27 Feb 2023 12:55:56 AM UTC, comment #3: 

Updating summary and reclassifying this ticket as invalid due to the following commit, as noted by Ingo in Bjarni in comment #2 and comment #1.


commit 5aa934e701ac96c48cad71eae39ddb5817a7399c
Author: G. Branden Robinson <g.branden.robinson@gmail.com>
Date:   Thu Feb 6 17:17:38 2020 +1100

    ms: Cease warning level manipulation.

    Stop ms macro package from manipulating warnings.

    * tmac/s.tmac: Remove code block that attempted to enable all
      warnings "only if none are given on the command line".  It did this by
      simply comparing the value of the warn register (\n[.warn]) against
      the default value; but of course, a user could specify -w options that
      exactly matched the default and the test would not be able to tell,
      causing puzzling and undesired behavior.  Furthermore, the hard-coded
      default was out of date and did not correspond to recent releases of
      groff.  If you want all warnings on, use the ".warn" request with no
      arguments in your ms document or pass "-w w" to groff (see troff(1) or
      the Texinfo manual for more on warnings).

    Thanks to Bjarni Ingi Gislason for bringing this issue to our attention.

    Resolves <https://savannah.gnu.org/bugs/?57583>.


G. Branden Robinson <gbranden>
Group administrator
Sat 08 Feb 2020 06:31:26 PM UTC, comment #2: 

Fixed in 5aa934e701ac96c48cad71eae39ddb5817a7399c Feb 6 17:17:38 2020 +1100.

Ingo Schwarze <schwarze>
Group Member
Thu 06 Feb 2020 09:54:42 PM UTC, comment #1: 

  This report is now obsolete as the relevant lines have been removed.

See #57583.

Bjarni Ingi Gislason <bjarniig>
Sun 28 Jan 2018 02:55:40 PM UTC, original submission:  


From 7243abaf23a443ad4808a18d95b0d2bb69e49446 Mon Sep 17 00:00:00 2001
From: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
Date: Sun, 28 Jan 2018 14:48:56 +0000
Subject: [PATCH] s.tmac: Update default value for register ".warn"

  The default value is now for:

char (1), number (2), break (4), space (65,536), font (131,072), and
file (1,048,576).

Signed-off-by: Bjarni Ingi Gislason <bjarniig@rhi.hi.is>
---
 tmac/s.tmac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tmac/s.tmac b/tmac/s.tmac
index e8edf98b..99b58c3c 100644
--- a/tmac/s.tmac
+++ b/tmac/s.tmac
@@ -25,7 +25,7 @@ along with this program.  If not, see <http://www.gnu.org/licenses/>.
 .        ab The groff ms macros do not work in compatibility mode.
 .\" Enable warnings (only if none are given on the command line).
 .\" You can delete this if you want.
-.if (\n[.warn] == 65543) .warn
+.if (\n[.warn] == 1245191) .warn
 .\" See if already loaded.
 .if r GS .nx
 .mso devtag.tmac
--
2.15.1


Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by gbranden (Posted a comment)
  • -email is unavailable- added by schwarze (Posted a comment)
  • -email is unavailable- added by bjarniig (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-02-27 gbranden StatusFixed Invalid
        Planned Release1.23.0 None
        SummaryStop the ms macro package from manipulating warnings [ms] update warning manipulation to use newer troff default
    2020-02-08 schwarze Severity3 - Normal 2 - Minor
        StatusNone Fixed
        Assigned toNone gbranden
        Open/ClosedOpen Closed
        Planned ReleaseNone 1.23.0
        Summary[PATCH] s.tmac: Update default value for register &quot;.warn&quot; Stop the ms macro package from manipulating warnings

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code