bugGNU nano - Bugs: bug #52834, compiling nano 2.9.2 with...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #52834: compiling nano 2.9.2 with --enable-{tiny,nanorc,color} fails

Submitter:  Will <akiko>
Submitted:  Mon 08 Jan 2018 06:33:37 AM UTC
   
 
Severity:  3 - Normal Status:  Fixed
Assigned to:  bens Open/Closed:  Closed

Jump to the original submission

Tue 30 Jan 2018 08:59:24 AM UTC, comment #9: 

The fix has been released in 2.9.3.  Thanks for reporting.

Benno Schulenberg <bens>
Group administrator
Wed 10 Jan 2018 04:36:00 PM UTC, comment #8: 

So... if it were possible to have color and a nanorc in a tiny nano but to disable the linter and still have the help lines well-arranged, you would like that?  If yes, then it seems the time has come to "fix" bug #50080.  :)

Benno Schulenberg <bens>
Group administrator
Wed 10 Jan 2018 09:02:18 AM UTC, comment #7: 

Yeah, I tried to remove linter too, and ran in the same problem. ;-) So for now the small define fix works well.

Will <akiko>
Tue 09 Jan 2018 12:37:11 PM UTC, comment #6: 

Disabling the entire linter in the tiny version is too big a change: it messes up the help lines.  So I've applied your fix, commit 7947d9d2.  Thanks.

Benno Schulenberg <bens>
Group administrator
Tue 09 Jan 2018 10:12:42 AM UTC, comment #5: 

Attached patch should fix the build issue, by excluding the whole linter from the tiny version.

(file #42875)

Benno Schulenberg <bens>
Group administrator
Tue 09 Jan 2018 10:03:44 AM UTC, comment #4: 

By the way, do you want to have the linter in your tiny nano?  Because if you want a tiny nano, you would want to get rid of as much code as possible, no?

Benno Schulenberg <bens>
Group administrator
Tue 09 Jan 2018 09:59:08 AM UTC, comment #3: 

Ah.  Okay, the reproducer is (after a make clean):

  ./configure --enable-tiny --enable-nanorc --enable-color

That's a combination that the nano-regress script doesn't check because the color option depends on the nanorc option.

Thanks for reporting, working on it.

Benno Schulenberg <bens>
Group administrator
Tue 09 Jan 2018 09:18:20 AM UTC, comment #2: 

I build nano as part of the OpenADK buildsystem. The full list of arguments given to configure is quite complex because of OpenADK. Here is the list of all pure configure arguments:

    --build=x86_64-linux-gnu \
    --host=x86_64-openadk-linux \
    --target=x86_64-openadk-linux \
    --program-prefix= \
    --program-suffix= \
    --prefix=/usr \
    --bindir=/usr/bin \
    --datadir=/usr/share \
    --mandir=/usr/share/man \
    --libexecdir=/usr/libexec \
    --localstatedir=/var \
    --sysconfdir=/etc \
    --disable-nls \
    --enable-shared \
    --enable-static \
    --disable-dependency-tracking \
    --disable-libtool-lock \
    --enable-nanorc --enable-color --enable-tiny --enable-multibuffer --disable-utf8 --disable-wrapping-as-root
configure: WARNING: unrecognized options: --enable-shared, --enable-static, --disable-libtool-lock

Exactly this list was used with nano 2.8.5 before and worked fine. The build host is a pure AMD64 Debian 8.0 and plain GNU Make 4.0, which is part of this Debian version.

Will <akiko>
Mon 08 Jan 2018 06:21:52 PM UTC, comment #1: 

Hmm...  How do you build your nano tiny?  Because... your patch changes something in do_linter(), but a tiny nano should not include the linter, so that function should not be getting compiled at all.  So how come that your compilation fails there?  What options did you pass to ./configure?

(I did find a compilation failure when configuring nano with --enable-tiny --enable-justify, and a patch for that has been pushed to git.)

It seems you are using something other than GNU make.  On what platform are you building nano?

Benno Schulenberg <bens>
Group administrator
Mon 08 Jan 2018 06:33:37 AM UTC, original submission:  

Building nano tiny fails with the following error message:

text.c: In function 'do_linter':
text.c:3038:10: error: 'openfilestruct' has no member named 'mark'
  openfile->mark = NULL;
          ^
Makefile:1572: recipe for target 'text.o' failed

Looks like there is a NANO_TINY define missing. Attached a patch that resolves this issue.

Will <akiko>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Posted a comment)
  • -email is unavailable- added by akiko (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 9 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-01-30 bens Open/ClosedOpen Closed
    2018-01-23 bens Summarycompiling nano 2.9.2 with --enable(tiny,nanorc,color} fails compiling nano 2.9.2 with --enable-{tiny,nanorc,color} fails
    2018-01-09 bens StatusConfirmed Fixed
    2018-01-09 bens Attached File- Added exclude-linter-from-tiny.patch, #42875
    2018-01-09 bens SummaryCompiling nano 2.9.2 tiny fails compiling nano 2.9.2 with --enable(tiny,nanorc,color} fails
    2018-01-09 bens StatusNeed Info Confirmed
    2018-01-08 bens StatusNone Need Info
        Assigned toNone bens
    2018-01-08 akiko Attached File- Added fix-missing-tiny-define.patch, #42868

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code