bugGNU nano - Bugs: bug #51809, PageUp can get stuck on...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51809: PageUp can get stuck on softwrapped tabs on a small screen

Submitter:  David Lawrence Ramsey <dolorous>
Submitted:  Sun 20 Aug 2017 11:32:13 PM UTC
   
 
Severity:  3 - Normal Status:  Fixed
Assigned to:  bens Open/Closed:  Closed

Tue 22 Aug 2017 02:13:05 PM UTC, comment #5: 

Fixed in git, fc367a32.

Benno Schulenberg <bens>
Group administrator
Mon 21 Aug 2017 08:04:11 PM UTC, comment #4: 

Okay.  I do actually prefer the approach in that patch, but I wasn't sure which way you wanted to go.  Looks good to me.

David Lawrence Ramsey <dolorous>
Group Member
Mon 21 Aug 2017 07:54:13 PM UTC, comment #3: 

I think the attached patch avoids <Up> and <PageUp> getting stuck -- simply by not using proper_x(), which is the reason they get stuck.  The resultant movement (with overwide tabs) is erratic in the same way.  So... instead of workarounds, better have simple code that has a small deficiency.

(file #41606)

Benno Schulenberg <bens>
Group administrator
Mon 21 Aug 2017 12:04:00 AM UTC, comment #2: 

And here's a simpler way to reproduce the original problem:

In an 80x9 terminal, with current git, run:

./nano --ignore --soft -T241 NEWS

David Lawrence Ramsey <dolorous>
Group Member
Sun 20 Aug 2017 11:36:10 PM UTC, comment #1: 

I've ported the same temporary fix for Up's getting stuck to PageUp in the attached patch against git 243380c.

With this applied, the cursor will at least move up one character, which, in the cases where it gets stuck, should be at least part of the minimum 3 rows.  (The commit message doesn't mention the bug number because it's a temporary fix.)

(file #41604)

David Lawrence Ramsey <dolorous>
Group Member
Sun 20 Aug 2017 11:32:13 PM UTC, original submission:  

In an 80x6 terminal, with current git, run:

./nano --ignore --soft --nohelp --morespace -T241 NEWS

Press PageDown, and then PageUp. PageUp will mot move the cursor at all.  It's supposed to move a minimum of 3 rows, but the overly long tab prevents that.

David Lawrence Ramsey <dolorous>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Updated the item)
  • -email is unavailable- added by dolorous (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-08-22 bens StatusIn Progress Fixed
        Open/ClosedOpen Closed
    2017-08-21 bens Attached File- Added dont-compensate-the-ups.patch, #41606
        StatusNone In Progress
        Assigned toNone bens
    2017-08-20 dolorous Attached File- Added 0001-moving-get-PageUp-unstuck-over-a-sprawling-tab-on-a-.patch, #41604

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code