bugGNU nano - Bugs: bug #51809, PageUp can get stuck on...

 
 

bug #51809: PageUp can get stuck on softwrapped tabs on a small screen

Submitted by:  David Lawrence Ramsey <dolorous>
Submitted on:  Sun 20 Aug 2017 11:32:13 PM UTC  
 
Severity: 3 - NormalStatus: Fixed
Assigned to: Benno Schulenberg <bens>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 22 Aug 2017 02:13:05 PM UTC, comment #5:

Fixed in git, fc367a32.

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Mon 21 Aug 2017 08:04:11 PM UTC, comment #4:

Okay. I do actually prefer the approach in that patch, but I wasn't sure which way you wanted to go. Looks good to me.

David Lawrence Ramsey <dolorous>
Project Administrator
Mon 21 Aug 2017 07:54:13 PM UTC, comment #3:

I think the attached patch avoids <Up> and <PageUp> getting stuck -- simply by not using proper_x(), which is the reason they get stuck. The resultant movement (with overwide tabs) is erratic in the same way. So... instead of workarounds, better have simple code that has a small deficiency.

(file #41606)

Benno Schulenberg <bens>
Project AdministratorIn charge of this item.
Mon 21 Aug 2017 12:04:00 AM UTC, comment #2:

And here's a simpler way to reproduce the original problem:

In an 80x9 terminal, with current git, run:

./nano --ignore --soft -T241 NEWS

David Lawrence Ramsey <dolorous>
Project Administrator
Sun 20 Aug 2017 11:36:10 PM UTC, comment #1:

I've ported the same temporary fix for Up's getting stuck to PageUp in the attached patch against git 243380c.

With this applied, the cursor will at least move up one character, which, in the cases where it gets stuck, should be at least part of the minimum 3 rows. (The commit message doesn't mention the bug number because it's a temporary fix.)

(file #41604)

David Lawrence Ramsey <dolorous>
Project Administrator
Sun 20 Aug 2017 11:32:13 PM UTC, original submission:

In an 80x6 terminal, with current git, run:

./nano --ignore --soft --nohelp --morespace -T241 NEWS

Press PageDown, and then PageUp. PageUp will mot move the cursor at all. It's supposed to move a minimum of 3 rows, but the overly long tab prevents that.

David Lawrence Ramsey <dolorous>
Project Administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Updated the item)
  • -unavailable- added by dolorous (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 6 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 22 Aug 2017 02:13:05 PM UTCbensStatusIn Progress=>Fixed
      Open/ClosedOpen=>Closed
    Mon 21 Aug 2017 07:54:13 PM UTCbensAttached File-=>Added dont-compensate-the-ups.patch, #41606
      StatusNone=>In Progress
      Assigned toNone=>bens
    Sun 20 Aug 2017 11:36:10 PM UTCdolorousAttached File-=>Added 0001-moving-get-PageUp-unstuck-over-a-sprawling-tab-on-a-.patch, #41604

    Back to the top


    Powered by Savane 3.1-cleanup1