bugGNU nano - Bugs: bug #51768, in a 1-column terminal, nano can...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #51768: in a 1-column terminal, nano can lock up in a file with chunk-straddling tabs

Submitter:  David Lawrence Ramsey <dolorous>
Submitted:  Wed 16 Aug 2017 07:50:13 PM UTC
   
 
Severity:  3 - Normal Status:  Fixed
Assigned to:  dolorous Open/Closed:  Closed

Tue 22 Aug 2017 03:08:19 PM UTC, comment #5: 

This was a special case of bug #51770.  Thus closing.

Benno Schulenberg <bens>
Group administrator
Thu 17 Aug 2017 06:11:13 PM UTC, comment #4: 

I just tested it to be sure, and it is fixed by that commit.  Thanks.

David Lawrence Ramsey <dolorous>
Group Member
Thu 17 Aug 2017 05:54:50 PM UTC, comment #3: 

I haven't actually tested the 1-column recipe, but I suppose your conclusion from comment #2 is right.  So this should be fixed by commit f08d169a.

Benno Schulenberg <bens>
Group administrator
Thu 17 Aug 2017 02:36:54 AM UTC, comment #2: 

Never mind the last patch; after more testing, the lockup turned out to be a different manifestation of bug #51770, and the much simpler patch there will fix it.

David Lawrence Ramsey <dolorous>
Group Member
Wed 16 Aug 2017 07:54:26 PM UTC, comment #1: 

The easiest fix I can think of is to disable the special handling of chunk-straddling tabs if the column is one terminal wide, as that handling only makes sense on terminals wide enough to have tabs straddle chunks in the first place.

The attached patch accomplishes this.

(file #41545)

David Lawrence Ramsey <dolorous>
Group Member
Wed 16 Aug 2017 07:50:13 PM UTC, original submission:  

This can be reproduced as follows:

1. Start an 80x24 xterm, and start current git of nano (807f5c2) with:

./nano --ignore --softwrap tabtest.txt

2. Resize the xterm horizontally until it's only 1 column wide.

3. Press PageDown twice.

4. Resize the xterm horizontally until it's back to 80 columns wide.  nano will be locked up.

If --atblanks is used as well as --softwrap, the same problem occurs.

David Lawrence Ramsey <dolorous>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Posted a comment)
  • -email is unavailable- added by dolorous (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-08-22 bens Open/ClosedOpen Closed
    2017-08-17 bens StatusNone Fixed
        Assigned toNone dolorous
    2017-08-16 dolorous Attached File- Added 0001-softwrap-disable-chunk-straddling-tab-handling-in-1-.patch, #41545
    2017-08-16 dolorous Attached File- Added tabtest.txt, #41544

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code