bugGNU nano - Bugs: bug #51768, in a 1-column terminal, nano can...

 
 

bug #51768: in a 1-column terminal, nano can lock up in a file with chunk-straddling tabs

Submitted by:  David Lawrence Ramsey <dolorous>
Submitted on:  Wed 16 Aug 2017 07:50:13 PM UTC  
 
Severity: 3 - NormalStatus: Fixed
Assigned to: David Lawrence Ramsey <dolorous>Open/Closed: Closed

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 22 Aug 2017 03:08:19 PM UTC, comment #5:

This was a special case of bug #51770. Thus closing.

Benno Schulenberg <bens>
Project Administrator
Thu 17 Aug 2017 06:11:13 PM UTC, comment #4:

I just tested it to be sure, and it is fixed by that commit. Thanks.

David Lawrence Ramsey <dolorous>
Project AdministratorIn charge of this item.
Thu 17 Aug 2017 05:54:50 PM UTC, comment #3:

I haven't actually tested the 1-column recipe, but I suppose your conclusion from comment #2 is right. So this should be fixed by commit f08d169a.

Benno Schulenberg <bens>
Project Administrator
Thu 17 Aug 2017 02:36:54 AM UTC, comment #2:

Never mind the last patch; after more testing, the lockup turned out to be a different manifestation of bug #51770, and the much simpler patch there will fix it.

David Lawrence Ramsey <dolorous>
Project AdministratorIn charge of this item.
Wed 16 Aug 2017 07:54:26 PM UTC, comment #1:

The easiest fix I can think of is to disable the special handling of chunk-straddling tabs if the column is one terminal wide, as that handling only makes sense on terminals wide enough to have tabs straddle chunks in the first place.

The attached patch accomplishes this.

(file #41545)

David Lawrence Ramsey <dolorous>
Project AdministratorIn charge of this item.
Wed 16 Aug 2017 07:50:13 PM UTC, original submission:

This can be reproduced as follows:

1. Start an 80x24 xterm, and start current git of nano (807f5c2) with:

./nano --ignore --softwrap tabtest.txt

2. Resize the xterm horizontally until it's only 1 column wide.

3. Press PageDown twice.

4. Resize the xterm horizontally until it's back to 80 columns wide. nano will be locked up.

If --atblanks is used as well as --softwrap, the same problem occurs.

David Lawrence Ramsey <dolorous>
Project AdministratorIn charge of this item.

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by bens (Posted a comment)
  • -unavailable- added by dolorous (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 22 Aug 2017 03:08:19 PM UTCbensOpen/ClosedOpen=>Closed
    Thu 17 Aug 2017 05:54:50 PM UTCbensStatusNone=>Fixed
      Assigned toNone=>dolorous
    Wed 16 Aug 2017 07:54:26 PM UTCdolorousAttached File-=>Added 0001-softwrap-disable-chunk-straddling-tab-handling-in-1-.patch, #41545
    Wed 16 Aug 2017 07:50:13 PM UTCdolorousAttached File-=>Added tabtest.txt, #41544

    Back to the top


    Powered by Savane 3.1-cleanup1