bugGNU troff - Bugs: bug #51609, [PATCH] src: hdtbl.tmac-u: Fix one...

 
 

bug #51609: [PATCH] src: hdtbl.tmac-u: Fix one formatting and one bug

Submitted by:  Bjarni Ingi Gislason <bjarniig>
Submitted on:  Fri 28 Jul 2017 11:17:23 PM UTC  
 
Category: Macro - othersSeverity: 3 - Normal
Item Group: NoneStatus: Fixed
Privacy: PublicAssigned to: G. Branden Robinson <gbranden>
Open/Closed: OpenPlanned Release: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Thu 02 Nov 2017 07:03:26 AM UTC, comment #11:

Thanks, Werner. I've fixed the two stragglers.

G. Branden Robinson <gbranden>
Project MemberIn charge of this item.
Wed 01 Nov 2017 08:15:00 AM UTC, comment #10:
  • You can configure git to not shout if there are trailing spaces...
  • I consider it good practise to always finish `.ds' (with a string argument) and friends with `\"'. In case some are missing I suggest to add them.
Werner LEMBERG <wl>
Project Administrator
Wed 01 Nov 2017 07:13:59 AM UTC, comment #9:

Thanks, Werner. I guess I should mention that I was aware of that, but we have git these days shouting warnings at us if we add trailing whitespace to lines, and the practice is not consistently followed in the file. So I was not sure.

$ grep -nE '^\.\s+ds' contrib/hdtbl/hdtbl.tmac-u | grep -v '"$'
114:. ds t*FN \\[.F]
115:. ds t*LN \\[.c]
172:. ds tbc\\n[t#]
182:. ds width
248:. ds a\\n[t#]
288:. ds #t#r \\n[t#]\\n[tr#\\n[t#]]\" table row identifier
343:. ds #trc \\[#t#r]\\n[c#\\*[#t#r]]\" table cell identifier
410:. ds *
451:. ds #t#r \\n[t#]\\n[tr#\\n[t#]]\" refresh table row identifier
824:. ds #t#r \\n[t#]\\n[tr#\\n[t#]]\" refresh table row identifier

G. Branden Robinson <gbranden>
Project MemberIn charge of this item.
Wed 01 Nov 2017 07:09:24 AM UTC, comment #8:

> Can someone tell me what the point is of having all these string definitions end with a null comment?


This is even in the info manual (section 5.19, `Strings'): It prevents accidental addition of trailing spaces, which are not ignored by `.ds'.

Werner LEMBERG <wl>
Project Administrator
Wed 01 Nov 2017 03:01:23 AM UTC, comment #7:

The cosmetic half of this ticket is fixed in d0f0f3fffadaa2c28e8aabe919dfbf6ca3a73d61.

G. Branden Robinson <gbranden>
Project MemberIn charge of this item.
Wed 01 Nov 2017 03:00:21 AM UTC, comment #6:

By "all these", I mean:

42 .ds t*hl s\"
43 .ds t*vl s\"
44 .ds t*tal l\"
45 .ds t*hal b\"
46 .ds t*val t\"
47 .ds t*ff \\n[.fam]\"
48 .ds t*fst \\n[.f]\"
49 .ds t*fsz 1 1\"
50 .ds t*fgc red4\"
51 .ds t*bgc bisque\"
52 .ds t*bc red4\"

65 .ds t*cptn "".sp .4" \
66 ".t*pv 1.0 1.0" \
67 ".ad l" \
68 "\m[\\[tfgc]]Table \\n+[tcptn]:\0\c\k"\"

73 .\" for better error messages
74 .ds nth-1 st\"
75 .ds nth-2 nd\"
76 .ds nth-3 rd\"

G. Branden Robinson <gbranden>
Project MemberIn charge of this item.
Wed 01 Nov 2017 02:58:01 AM UTC, comment #5:

Can someone tell me what the point is of having all these string definitions end with a null comment?

G. Branden Robinson <gbranden>
Project MemberIn charge of this item.
Mon 30 Oct 2017 03:36:08 AM UTC, comment #4:

Thanks, Bjarni!

G. Branden Robinson <gbranden>
Project MemberIn charge of this item.
Sun 29 Oct 2017 06:43:15 PM UTC, comment #3:
Bjarni Ingi Gislason <bjarniig>
Sun 29 Oct 2017 04:51:35 PM UTC, comment #2:

gbranden: No, this is indeed an empty ticket without any information whatsoever. You should probably close it as invalid.

Ingo Schwarze <schwarze>
Sun 29 Oct 2017 02:22:58 AM UTC, comment #1:

I see neither an attachment nor a non-blank "original submission" to this bug. Is the problem on my end?

G. Branden Robinson <gbranden>
Project MemberIn charge of this item.
Fri 28 Jul 2017 11:17:23 PM UTC, original submission:
Bjarni Ingi Gislason <bjarniig>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by wl (Posted a comment)
  • -unavailable- added by schwarze (Posted a comment)
  • -unavailable- added by gbranden (Posted a comment)
  • -unavailable- added by bjarniig (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 8 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Wed 01 Nov 2017 07:20:37 AM UTCgbrandenStatusIn Progress=>Fixed
    Wed 01 Nov 2017 07:13:59 AM UTCgbrandenStatusNeed Info=>In Progress
    Wed 01 Nov 2017 03:27:44 AM UTCgbrandenStatusIn Progress=>Need Info
    Wed 01 Nov 2017 02:23:17 AM UTCgbrandenStatusNone=>In Progress
      Assigned toNone=>gbranden
    Mon 30 Oct 2017 03:36:08 AM UTCgbrandenStatusNeed Info=>None
    Sun 29 Oct 2017 02:22:58 AM UTCgbrandenCategoryNone=>Macro - others
      StatusNone=>Need Info

    Back to the top


    Powered by Savane 3.1-cleanup1