bugmake - Bugs: bug #51159, pselect jobserver stuck at read...

 
 

bug #51159: pselect jobserver stuck at read does not reap children

Submitted by:  Koen Van Hoof <kvho>
Submitted on:  Fri 02 Jun 2017 10:44:13 AM UTC  
 
Severity: 3 - NormalItem Group: Bug
Status: FixedPrivacy: Public
Assigned to: Paul D. Smith <psmith>Open/Closed: Closed
Component Version: 4.2.1Operating System: POSIX-Based
Fixed Release: SCMTriage Status: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sun 04 Jun 2017 11:04:26 PM UTC, comment #3:

I actually didn't notice the patch attached here before I created a fix since I didn't scroll down far enough (my bad), but the fix I wrote is more-or-less equivalent, although with some extras.

A fix has been pushed and will be in the next release. Thank you for filing a report!

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Fri 02 Jun 2017 05:36:41 PM UTC, comment #2:

This does look like a promising diagnosis. I'll look at it this weekend.

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Fri 02 Jun 2017 03:43:09 PM UTC, comment #1:

Is this part of:

bug #49014: Zombies in parallel builds with pselect code

But with the key missing ingredient - a diagnosis - and a fix?

Martin Dorey <mdorey>
Fri 02 Jun 2017 10:44:13 AM UTC, original submission:

When using parallel recurse make, several child make processes will be waiting in pselect.
When some make is writing a token in the pipe, several of these processes will leave the pselect, and trying to read the pipe.
Only 1 will actually get the token. All others will be blocked in the read.
Eventually tokens will be written to the pipe, unblocking these make processes.

Solution : make the pipe non blocking, in order for all the processes that miss the token to call pselect again.

Koen Van Hoof <kvho>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #40839:  patch added by kvho (902B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by psmith (Posted a comment)
  • -unavailable- added by mdorey (Posted a comment)
  • -unavailable- added by kvho (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 5 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Sun 04 Jun 2017 11:04:26 PM UTCpsmithStatusNone=>Fixed
      Assigned toNone=>psmith
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>SCM
    Fri 02 Jun 2017 10:44:13 AM UTCkvhoAttached File-=>Added patch, #40839

    Back to the top


    Powered by Savane 3.1-cleanup1