GNU nano - Bugs: bug #50997, with softwrap, the replace...
You are not allowed to post comments on this tracker with your current authentication level.
bug #50997: with softwrap, the replace highlight can be drawn in the wrong place
Submitter: | David Lawrence Ramsey <dolorous> | ||
Submitted: | Wed 10 May 2017 09:56:43 PM UTC | ||
Severity: | 4 - Important | Status: | Fixed |
Assigned to: | bens | Open/Closed: | Closed |
Fri 12 May 2017 08:18:32 PM UTC, comment #4: |
Benno Schulenberg <bens> |
Fri 12 May 2017 07:49:09 PM UTC, comment #3: Looks good to me, after some quick testing. |
David Lawrence Ramsey <dolorous> |
Thu 11 May 2017 08:34:15 PM UTC, comment #2: Attached patch fixes it for me.
|
Benno Schulenberg <bens> |
Thu 11 May 2017 07:47:29 PM UTC, comment #1: Confirmed. In former times, the search/replace routines used to set placewewant, so then this would have worked. But they don't do that anymore, so placewewant does not correspond with [current, current_x] when place_the_cursor() is called in this case. It is in fact a misuse of place_the_cursor() -- it is not about putting the cursor at the point where extra characters will be inserted when the user starts typing, here it is just about translating [current, current_x] to a [row, col] coordinate on the screen and moving the cursor there in order to write the spotlighted word. In this case it also unnecessarily (and probably wrongly) changes current_y.
|
Benno Schulenberg <bens> |
Wed 10 May 2017 09:56:43 PM UTC, original submission:
1. With current git and the attached file, run:
|
David Lawrence Ramsey <dolorous> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-05-19 | bens | Open/Closed | Open | Closed | |
2017-05-12 | bens | Status | In Progress | Fixed | |
2017-05-11 | bens | Attached File | - | Added 0001-replacing-don-t-let-placewewant-influence-the-placem.patch, #40668 | |
Status | None | In Progress | |||
2017-05-11 | bens | Severity | 3 - Normal | 4 - Important | |
Assigned to | None | bens | |||
2017-05-10 | dolorous | Attached File | - | Added nanobug.txt, #40659 |
Powered by Savane 3.13-4448.
Corresponding source code
Pushed, 28beb3f9. Thanks for testing.