bugGNU Wget - Bugs: bug #50219, ftp.c calls abort() under certain...

 
 

bug #50219: ftp.c calls abort() under certain error conditions

Submitter:  Tim Ruehsen <rockdaboot>
Submitted:  Fri 03 Feb 2017 10:40:55 AM UTC
   
 
Category:  Program Logic Severity:  3 - Normal
Priority:  5 - Normal Status:  None
Privacy:  Public Assigned to:  None
Originator Name:  Open/Closed:  Open
Release:  trunk Operating System:  None
Reproducibility:  None Fixed Release:  None
Planned Release:  None Regression:  None
Work Required:  1 - Days Patch Included:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Fri 03 Feb 2017 10:40:55 AM UTC, original submission:  

A potential long runner like Wget should never call abort().

In src/ftp.c are some switch() with incomplete testing and defaulting to call abort(). This may stop Wget randomly.

Example:
ftp.c, L585+:
err = ftp_syst ...
switch (err)...

'err' may become WRITEFAILED on write errors. This is not cased by the switch and would got into the default case that calls abort().

Solution:
Never call abort(). Instead print a precise error message and return the error to the calling function.

Tim Ruehsen <rockdaboot>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rockdaboot (Submitted the item)

    •  

    No changes have been made to this item

    Back to the top

    Copyright © 2024 Free Software Foundation, Inc.
    Verbatim copying and distribution of this entire article is permitted in any medium, provided this notice is preserved.
    The Levitating, Meditating, Flute-playing Gnu logo is a GNU GPL'ed image provided by the Nevrax Design Team.
    Page source code

    Powered by Savane 3.14-3b9d.
    Corresponding source code