bugGNU Screen - Bugs: bug #49189, segfault in src/authentication.c...

 
 

bug #49189: segfault in src/authentication.c fix

Submitter:  Arseniy Simonov <catterer>
Submitted:  Mon 26 Sep 2016 11:41:45 AM UTC
   
 
Category:  Crash/Freeze/Infloop Severity:  3 - Normal
Priority:  * 5 - Normal Status:  Fixed
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Release:  Cur Dev Sources
Fixed Release:  5.0.0 Planned Release:  None
Work Required:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 03 Oct 2016 07:21:28 PM UTC, comment #1: 

Thanks,
applied to master

Amadeusz Sławiński <amade>
Group administrator
Mon 26 Sep 2016 11:41:45 AM UTC, original submission:  


$ git diff
diff --git a/src/authentication.c b/src/authentication.c
index 4c02eb6..27f109e 100644
--- a/src/authentication.c
+++ b/src/authentication.c
@@ -124,8 +124,10 @@ static bool CheckPassword() {
        p = getspnam(ppp->pw_name);
        seteuid(uid);
        setegid(gid);
-       if (p == NULL)
+       if (p == NULL) {
                fprintf(stderr, "can't open passwd file\n");
+                return false;
+        }

        printf("\ascreen used by %s%s<%s> on %s.\n",
                ppp->pw_gecos, ppp->pw_gecos[0] ? " " : "", ppp->pw_name, HostName);


Arseniy Simonov <catterer>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by anaumov (Updated the item)
  • -email is unavailable- added by amade (Posted a comment)
  • -email is unavailable- added by catterer (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2023-01-22 anaumov Open/ClosedOpen Closed
        Fixed ReleaseNone 5.0.0
    2016-10-03 amade StatusNone Fixed

    Back to the top

    Powered by Savane 3.13-d3ae.
    Corresponding source code