bugGNU Screen - Bugs: bug #45359, Make fails in utmp.c under cygwin

 
 

bug #45359: Make fails in utmp.c under cygwin

Submitted by:  None
Submitted on:  Fri 19 Jun 2015 06:20:22 PM UTC  
Votes:  10  
 
Category:  Build/Install Severity:  3 - Normal
Priority:  5 - Normal Status:  Need Investigation
Privacy:  Public Assigned to:  Amadeusz Sławiński <amade>
Open/Closed:  Open Release:  4.3.1
Fixed Release:  None Planned Release:  4.3.2
Work Required:  None

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

( Jump to the original submission)

Sat 05 Sep 2015 03:25:53 PM UTC, comment #7: 

Thanks! I will test it later.

Amadeusz Sławiński <amade>
Project AdministratorIn charge of this item.
Sat 05 Sep 2015 02:35:18 PM UTC, comment #6: 

Thanks.  Separately I developed the attached patch, which checks struct utmp for member ut_tv or ut_time, and uses either one accordingly.  Maybe a better approach?  Anyway it allows screen 4.3.1 to build in Cygwin.

(file #34815)

Andrew Schulman <andrex593>
Sat 05 Sep 2015 01:07:15 PM UTC, comment #5: 

Yes it fails when there is only utmp.h and no utmpx.h installed.
Will be fixed in 4.3.2 (fix available on screen-v4 branch)

Amadeusz Sławiński <amade>
Project AdministratorIn charge of this item.
Wed 02 Sep 2015 08:31:28 PM UTC, comment #4: 

Please reopen this bug.  As the OP pointed out, it exists in screen 4.3.1, not 4.03.0.  I confirm that in the latest Cygwin (2.2.1), build of 4.3.1 fails in utmp.c with

  utmp.c:634:4: error: ‘struct utmp’ has no member named ‘ut_tv’

and indeed, struct utmp has no such element in Cygwin.  From sys/utmp.h:

  struct utmp
  {
   short  ut_type;
   pid_t  ut_pid;
   char   ut_line[UT_LINESIZE];
   char  ut_id[UT_IDLEN];
   time_t ut_time;
   char   ut_user[UT_NAMESIZE];
   char   ut_host[UT_HOSTSIZE];
   long   ut_addr;
  };

What's the right solution?

Andrew Schulman <andrex593>
Thu 30 Jul 2015 01:27:26 AM UTC, comment #3: 

Just read more closely: it's 4.3.1 that I'm getting the same error building.

Jamie Walker <jjw>
Thu 30 Jul 2015 01:26:20 AM UTC, comment #2: 

Also fails for me under OpenBSD 5.7 amd64.

Jamie Walker <jjw>
Sun 28 Jun 2015 09:22:28 PM UTC, comment #1: 

Please upgrade your cygwin, it builds fine here on fresh install.

Amadeusz Sławiński <amade>
Project AdministratorIn charge of this item.
Fri 19 Jun 2015 06:20:22 PM UTC, original submission:  

While attempting to build screen-4.03.0 under cygwin32, the following error is encountered:

...
gcc -c -I. -I.  -DETCSCREENRC='"/usr/etc/screenrc"' -DSCREENENCODINGS='"/usr/share/screen/utf8encodings"' -DHAVE_CONFIG_H -DGIT_REV=\""`git describe --always 2>/dev/null`"\" \
     -g -O2 -D_GNU_SOURCE utmp.c
utmp.c: In function ‘makeuser’:
utmp.c:634:4: error: ‘struct utmp’ has no member named ‘ut_tv’
   u->ut_tv.tv_sec = now;
    ^
Makefile:82: recipe for target 'utmp.o' failed
make: *** [utmp.o] Error 1

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #34815:  screen-utmp.patch added by andrex593 (2KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by andrex593 (Posted a comment)
  • -email is unavailable- added by andrex593 (Voted in favor of this item)
  • -email is unavailable- added by jjw (Posted a comment)
  • -email is unavailable- added by amade (Posted a comment)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 10 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-09-05 amade StatusFixed => Need Investigation
    2015-09-05 andrex593 Attached File- => Added screen-utmp.patch, #34815
    2015-09-05 amade StatusNeed Investigation => Fixed
        ReleaseCur Dev Sources => 4.3.1
        Planned ReleaseNone => 4.3.2
    2015-09-03 amade StatusWorks For Me => Need Investigation
        Open/ClosedClosed => Open
    2015-09-02 andrex593 Carbon-Copy- => Added andrex593
    2015-06-28 amade StatusNone => Works For Me
        Assigned toNone => amade
        Open/ClosedOpen => Closed

    Back to the top


    Powered by Savane 3.6