bugGNU GRUB - Bugs: bug #43633, Add format option for ip addresses...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

bug #43633: Add format option for ip addresses to net_get_dhcp_option

Submitter:  Rob <rkliewer>
Submitted:  Tue 18 Nov 2014 09:33:17 PM UTC
   
 
Category:  User Interface Severity:  Major
Priority:  3 - Low Item Group:  Feature Request
Status:  None Privacy:  Public
Assigned to:  None Originator Name: 
Open/Closed:  Open Release:  Git master
Release:  Reproducibility:  Every Time
Planned Release:  2.03+

Thu 22 Jan 2015 08:56:56 PM UTC, comment #3: 

The patch has bugs. The least of them is memory leak. Please use ML for patches, not bugtracker.

Vladimir Serbinenko <phcoder>
Group administrator
Thu 20 Nov 2014 03:25:16 AM UTC, comment #2: 

Uploaded a new patch.  Changes to bootp.c have been simplified and net_get_dhcp_option documentation has been updated.

(file #32481)

Rob <rkliewer>
Wed 19 Nov 2014 06:31:08 PM UTC, comment #1: 

You do not really need endian conversion. Just print each byte directly.

grub_printf("%d.%d.%d.%d", ptr[0], ptr[1], ptr[2], ptr[3])

Please update documentation too.

Andrei Borzenkov <arvidjaar>
Group Member
Tue 18 Nov 2014 09:33:17 PM UTC, original submission:  

There are a few ip addresses, not automatically set to variables, that may be needed in a grub config (such as netmask and default router).  These may be retrieved with net_get_dhcp_option, but only as the decimal or hex representation of the 32-bit value.  I have included a patch that adds a new format specification 'ip' to net_get_dhcp_option, allowing values to be displayed/saved as ip strings.

Rob <rkliewer>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #32481:  add-ip-type-to-net-get-dhcp-option.patch added by rkliewer (2KiB - application/octet-stream)
file #32469:  bootp.c.patch added by rkliewer (1KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by phcoder (Posted a comment)
  • -email is unavailable- added by arvidjaar (Posted a comment)
  • -email is unavailable- added by rkliewer (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-10-11 phcoder Priority5 - Normal 3 - Low
    2016-03-02 phcoder Planned ReleaseNone 2.03+
    2014-11-20 rkliewer Attached File- Added add-ip-type-to-net-get-dhcp-option.patch, #32481
    2014-11-18 rkliewer Attached File- Added bootp.c.patch, #32469

    Back to the top

    Powered by Savane 3.13-8484.
    Corresponding source code