bugDenemo - Bugs: bug #35750, Completion of error handling

 
 

bug #35750: Completion of error handling

Submitter:  Markus Elfring <elfring>
Submitted:  Wed 07 Mar 2012 07:41:48 PM UTC
   
 
Category:  None Severity:  3 - Normal
Item Group:  None Status:  Postponed
Privacy:  Public Assigned to:  None
Originator Name:  Open/Closed:  Open
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 25 Apr 2013 05:04:58 PM UTC, comment #7: 


>How do you think about to encapsulate error detection and corresponding exception handling as a reusable aspect in your software?


I am afraid it doesn't chime with my interests, but if the code gets into better shape it could be taken up by others.


Richard Shann <rshann>
Group administrator
Thu 25 Apr 2013 01:37:51 PM UTC, comment #6: 

Thanks for another bit of clean-up.

How do you think about to encapsulate error detection and corresponding exception handling as a reusable aspect in your software?

Markus Elfring <elfring>
Thu 25 Apr 2013 01:29:04 PM UTC, comment #5: 

Thanks for drawing attention to the code in exportmidi.c - I have deleted it since it is just orphan code. I didn't manage to glean what aosd was glancing at the link you gave, but Denemo is some very ancient C code buried under an accretion of newer C and  with a scheme layer added, not very promising territory for a new approach to coding.

Richard Shann <rshann>
Group administrator
Thu 25 Apr 2013 12:36:57 PM UTC, comment #4: 

Thanks for this reopen of the bug report.

Would you like to check return values from functions like the following in the source file "exportmidi.c"?

  • putc ⇒ midi_byte
  • malloc ⇒ midi_change_event



Are you interested to apply aspect-oriented software development?

Markus Elfring <elfring>
Thu 25 Apr 2013 12:14:51 PM UTC, comment #3: 

Hmm, I obviously don't understand the issues here, so I had better leave this for others. It is not a hot topic, since no-one is uploading their additions to Denemo via this mechanism (in fact since denemo.org changed it may not even be possible).

Richard Shann <rshann>
Group administrator
Thu 25 Apr 2013 11:20:37 AM UTC, comment #2: 

I'm sorry. - I do not see that this open issue was improved with corresponding error detection and exception handling.

I find that a function like "process_http" is also an update candidate because of the unchecked return value from the write() call.

Markus Elfring <elfring>
Thu 25 Apr 2013 07:20:21 AM UTC, comment #1: 

the first of these has gone
the second is being returned to the scheme caller.

Richard Shann <rshann>
Group administrator
Wed 07 Mar 2012 07:41:48 PM UTC, original submission:  

I have looked at a few source files for your current software. I have noticed that some checks for return codes are missing.

Would you like to add more error handling for return values from functions like the following?

Markus Elfring <elfring>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rshann (Posted a comment)
  • -email is unavailable- added by elfring (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2013-04-25 rshann StatusFixed Postponed
        Open/ClosedClosed Open
    2013-04-25 rshann StatusNone Fixed
        Open/ClosedOpen Closed

    Back to the top

    Powered by Savane 3.13-3230.
    Corresponding source code