bugmake - Bugs: bug #34830, minor windows fixes

 
 

bug #34830: minor windows fixes

Submitted by:  Ozkan Sezer <sezero>
Submitted on:  Tue 15 Nov 2011 01:47:52 PM UTC  
 
Severity: 3 - NormalItem Group: None
Status: FixedPrivacy: Public
Assigned to: Paul D. Smith <psmith>Open/Closed: Closed
Component Version: 4.0Operating System: MS Windows
Fixed Release: 4.0Triage Status: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

(Jump to the original submission Jump to the original submission)

Tue 15 Nov 2011 11:10:22 PM UTC, comment #6:

With r1.159, job-server configury for --mingw* works, yes. Thank you. Hopefully nothing is broken for any other targets, with or without --disable-job-server and/or --enable-job-server.

For mingw configury, only bug #34818 remains unresolved now.

Ozkan Sezer <sezero>
Tue 15 Nov 2011 10:58:40 PM UTC, comment #5:

I already had a local fix for the configure disable thing; I was just waiting to be sure the variable change worked for you.

Committed the changes so please try the latest.

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Tue 15 Nov 2011 10:45:25 PM UTC, comment #4:

Your suggestion works, but --disable-job-server indeed doesn't work. How about the attached suggestion? It is actually an edited form of configure.in r1.157. Works with and without --disable-job-server properly for me.

(file #24384, file #24385)

Ozkan Sezer <sezero>
Tue 15 Nov 2011 10:17:50 PM UTC, comment #3:

Well, I can't test it because I have no Windows tools

Anyway the case statement is right. What it's trying to ask is if ANY value in the list is "no". The "*" will match zero or more chars, so this says, basically, if the string "/no/" appears anywhere in the string then set the value to no.

But, this should be totally irrelevant on windows because the next statement is:

Oh bummer, that's wrong. It should say make_cv_job_server=yes not make_cv_sa_restart=yes Cut and paste error.

Can you fix that and see if it helps?

Also, is that the right host_os value? Any others?

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Tue 15 Nov 2011 09:48:17 PM UTC, comment #2:

Thanks for applying the patches.

Hmm, configury still doesn't allow jobserver for windows. Looking around line 305 of configure.in, you are testing four variables but against "/no/" i.e. three. Changing to something like:

case "$ac_cv_func_pipe/$ac_cv_func_sigaction/$make_cv_sa_restart/$has_wait_nohang" in
//no/*) make_cv_job_server=no ;;
esac

... didn't work for me, either. I'm possibly doing something wrong
in there, or the "*" stuff doesn't work as expected.

Ozkan Sezer <sezero>
Tue 15 Nov 2011 09:17:45 PM UTC, comment #1:

OK I made these changes (or similar ones).

I also updated config.h.W32.template (the original patch only modified the generated file config.h.W32 and I didn't catch it).

I also added code to configure.in which SHOULD allow you to run configure for Windows targets and have it enable the jobserver by default. Hm. I just realized the new code won't allow you to disable the jobserver on W32/OS2 by running --disable-jobserver. Oops. Have to look at that.

Paul D. Smith <psmith>
Project AdministratorIn charge of this item.
Tue 15 Nov 2011 01:47:52 PM UTC, original submission:

Hi:

The attached small patch fixes a few format string warnings due to
DWORD type arguments, includes missing w32err.h headers in main.c
so that map_windows32_error_to_string() protoype is available to
it, removes an incorrect comment about a warning workaround from
main.c (gcc warns as well as msvc). Please review and consider for
applying.

As a side note, it is not possible to enable the new windows
jobsever functionality using the configury: I have to edit the
config.h to enable it. The config.h.W32.template also has it
disabled as of this writing.

Regards.

Ozkan Sezer <sezero>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files
file #24384:  configure.in added by sezero (15KiB - application/octet-stream - configury suggestion)
file #24385:  configure.in.diff added by sezero (1KiB - application/octet-stream - configury suggestion)
file #24379:  make-windows-misc.diff added by sezero (4KiB - application/octet-stream - misc windows fixes)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by psmith (Posted a comment)
  • -unavailable- added by sezero (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 7 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Tue 15 Nov 2011 10:45:25 PM UTCsezeroAttached File-=>Added configure.in, #24384
      Attached File-=>Added configure.in.diff, #24385
    Tue 15 Nov 2011 09:17:45 PM UTCpsmithStatusNone=>Fixed
      Assigned toNone=>psmith
      Open/ClosedOpen=>Closed
      Fixed ReleaseNone=>4.0
    Tue 15 Nov 2011 01:47:52 PM UTCsezeroAttached File-=>Added make-windows-misc.diff, #24379

    Back to the top


    Powered by Savane 3.1-cleanup1