bugGNU Wget - Bugs: bug #23107, Explicit URLs should always...

 
 

bug #23107: Explicit URLs should always traverse symlinks

Submitted by:  Micah Cowan <micahcowan>
Submitted on:  Tue 29 Apr 2008 03:44:10 PM UTC  
 
Category: Program LogicSeverity: 3 - Normal
Priority: 5 - NormalStatus: Confirmed
Privacy: PublicAssigned to: None
Originator Name: Open/Closed: Open
Release: NoneOperating System: None
Reproducibility: NoneFixed Release: None
Planned Release: 1.14Regression: Yes
Work Required: 0 - HoursPatch Included: None

Add a New Comment(Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Tue 16 Oct 2012 08:00:40 AM UTC, comment #3:

There is one issue, that the patch doesn't handle correctly. Particularly creation of the new URL from the path to which the symlink points is not handled always OK.

Example:
Original URL: ftp://192.168.100.12/333/link
SymLink: link -> ../001/002/byacc.tar.gz
New URL will be: ftp://192.168.100.12/../001/002/byacc.tar.gz

which will pass OK (but is not correct), but there are some cases, when it doesn't have to work as it should.

I'm not sure how to do this correctly, therefore I'm posting it here for discussion.

Tomas Hozza <thozza>
Mon 15 Oct 2012 01:52:42 PM UTC, comment #2:

Hi.

I wrote a patch for this issue. I have been thinking how to fix it the best way for some time and came up with this solution. I tried to write it as simple as possible and to keep the coding style you're using. I would like to ask you to have a look on it and give me some feedback. I would like this issue to be fixed, because I think is pretty bad. Patch is written for wget-1.14.

Thanks!

Regards,
Tomas Hozza

Tomas Hozza <thozza>
Fri 02 May 2008 06:32:16 PM UTC, comment #1:

The difference appears to be due to the fact that, without -N, we don't bother downloading a .listing first, since we don't need it. With -N, we do need the .listing (if the file exists, but apparently we get the .listing even when it doesn't), and then we're downloading it using ftp_retrieve_list instead of from wherever we normally retrieve it.

Micah Cowan <micahcowan>
Tue 29 Apr 2008 03:44:10 PM UTC, original submission:

To match documentation, and common expectations. See http://article.gmane.org/gmane.comp.web.wget.general/8029

Probably a regression, but not over 1.10.

Micah Cowan <micahcowan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach File(s):
   
   
Comment:
   

Attached Files

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by thozza (Updated the item)
  • -unavailable- added by micahcowan (Submitted the item)
  •  

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 2 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 15 Oct 2012 01:47:13 PM UTCthozzaAttached File-=>Added 0001-Fixed-error-when-downloading-SYMLINK-from-FTP.patch, #26771
    Thu 21 Aug 2008 11:27:51 PM UTCmicahcowanPlanned Release1.12=>1.14

    Back to the top


    Powered by Savane 3.1-cleanup1