bugGNU Wget - Bugs: bug #21403, configure.ac should use proper...

 
 

bug #21403: configure.ac should use proper check for siggetmask

Submitter:  Micah Cowan <micahcowan>
Submitted:  Tue 23 Oct 2007 09:18:43 PM UTC
   
 
Category:  Code Architecture Severity:  3 - Normal
Priority:  4 Status:  Needs Discussion
Privacy:  Public Assigned to:  None
Originator Name:  Open/Closed:  Open
Release:  None Operating System:  None
Reproducibility:  None Fixed Release:  None
Planned Release:  1.15 Regression:  None
Work Required:  0 - Hours Patch Included:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Sun 14 Sep 2008 07:25:25 AM UTC, comment #5: 

I really can't do anything with a patch against configure.

I did ping the autoconf folks with this, but honestly this would be a huge change for them, and I'm not even sure how it could be done. In the meantime, there are ways to do this on the Wget; namely, avoid the AC_CHECK_FUNCS, and write custom functions; at least for the ones we know will be important on Tru64.

Micah Cowan <micahcowan>
Sun 14 Sep 2008 04:32:12 AM UTC, comment #4: 

The error logged in config.log with cc on Tru64unix is here.

cc: Error: conftest.c, line 80: In this statement, the declaration for the proto
typed intrinsic function "sigsetjmp" is incorrect: the declared return type of "
char" is not consistent with the expected type of "int". (intrinsicdecler)
char sigsetjmp ();
-----^

Apparently, this test program is wrong in many ways.  Autoconf system should be modified, I suppose.  Not only function names but also function prototypes should be checked.

The simplest fix for configure is at the end.  I know this is not controllable from wget project, but from autoconf.

So I had prepared the previous patch for utils.c, as you know.

I realized that gcc on tru64unix allow the current source to compile.  You can simply note that we have to use gcc on tru64unix in order to avoid the bug of autoconf.

=====
--- configure.org       2008-06-30 10:41:15.000000000 +0900
+++ configure   2008-09-14 08:27:09.000000000 +0900
@@ -8856,7 +8856,7 @@
 #ifdef __cplusplus
 extern "C"
 #endif
-char $ac_func ();
+int $ac_func ();
 /* The GNU C library defines this for functions which it implements
     to always fail with ENOSYS.  Some functions are actually named
     something starting with __ and the normal name is an alias.  */

kazuro furukawa <furukawa>
Wed 02 Jul 2008 06:36:02 PM UTC, comment #3: 

Yeah, after digging in further, we did find that was the case.

I think the way I'd prefer to go, is to use a more accurate test in configure.ac to detect sigsetjmp; the current one fails because configure.ac tends to cheat a lot in its function-detectors, and in this case, it gets bit in the ass. :\

Increasing priority, and adjusting the title accordingly.

Micah Cowan <micahcowan>
Sun 29 Jun 2008 02:32:00 PM UTC, comment #2: 

Actually tru64unix supports sigsetjmp() and a modification for utils.c should not be necesary.  However, the configure script somehow decides sigsetjmp() is not available, then the issue around siggetmask() arises.  As a workaround I use attached patch.  I don't follow the discussion, but how about using this patch?

(file #15954)

kazuro furukawa <furukawa>
Fri 07 Dec 2007 11:29:16 PM UTC, comment #1: 

It only gets used when sigsetjmp isn't available, though, which in this example, is. Some problem with the config environ; waiting on Steven Schweda to help figure out what's going on.

Micah Cowan <micahcowan>
Tue 23 Oct 2007 09:18:43 PM UTC, original submission:  

siggetmask (used in utils.c) is an obsolete BSDism, and should not be used (also, Tru64 and VMS lack it); POSIX has sigprocmask(), which we should prefer if available; otherwise we should use nothing.

Thanks to Steven M Schweda for this issue.

Micah Cowan <micahcowan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #15954:  wget-1.11.3-utils.c.patch added by furukawa (1KiB - application/octet-stream - a simple patch for utils.c)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by furukawa (Updated the item)
  • -email is unavailable- added by micahcowan (Submitted the item)
  •  

    Follow 11 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-08-30 micahcowan Planned Release1.12 1.15
    2008-11-04 micahcowan Priority8 4
    2008-09-12 micahcowan Priority6 8
    2008-07-02 micahcowan Priority1 - Later 6
        SummaryShould not use siggetmask configure.ac should use proper check for siggetmask
    2008-06-29 furukawa Attached File- Added wget-1.11.3-utils.c.patch, #15954
    2008-01-27 micahcowan StatusConfirmed Needs Discussion
    2007-12-07 micahcowan Severity4 - Important 3 - Normal
        Priority9 - Immediate 1 - Later
    2007-10-23 micahcowan Severity3 - Normal 4 - Important
        Priority5 - Normal 9 - Immediate

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code