bugGNU Wget - Bugs: bug #20990, ftp_parse_unix_ls incorrectly...

 
 

bug #20990: ftp_parse_unix_ls incorrectly parses time when only one space separates time from preceeding token

Submitter:  None
Submitted:  Fri 07 Sep 2007 12:26:03 AM UTC
   
 
Category:  Program Logic Severity:  3 - Normal
Priority:  4 Status:  Fixed
Privacy:  Public Assigned to:  None
Originator Name:  William Siddall Originator Email:  -email is unavailable-
Open/Closed:  Closed Release:  1.10.2
Operating System:  Microsoft Windows Reproducibility:  Every Time
Fixed Release:  None Planned Release:  1.12
Regression:  None Work Required:  0 - Hours
Patch Included:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Thu 27 Aug 2009 08:03:42 AM UTC, comment #4: 

Not going to bother writing this test any time soon, and it's very likely to have been fixed, so closing until I hear otherwise.

Micah Cowan <micahcowan>
Thu 01 May 2008 10:51:56 PM UTC, comment #3: 

I believe this was also reported as fixed in Wget 1.11 already. Needs confirmation.

Micah Cowan <micahcowan>
Mon 14 Apr 2008 04:05:33 AM UTC, comment #2: 

This is quite possibly fixed among the various FTP improvements in Schweda's VMS-related improvements.

Micah Cowan <micahcowan>
Fri 07 Sep 2007 12:36:26 AM UTC, comment #1: 

This is probably the root cause behind #20800.

William Siddall <williamsiddall>
Fri 07 Sep 2007 12:26:03 AM UTC, original submission:  

Running WGET 1.10.2 on Windows XP, with cygwin, compiled from source.  In ftp-ls.c, line 223:
  while (t > line && ISDIGIT (*t))
    --t;
What is the purpose of this code?  See the attached .listing file, at line 15.  Notice that the file size (247976) is separated from the previous token by a single space.  Before entering the while loop, *t is '2'.  After exiting the while loop, *t is '\0', the null terminator of the previous token.  This causes line 232 to return 0 as the size.

If the while loop is, in fact, doing something useful, t should be incremented after the exit from the while.

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #13892:  .listing added by None (2KiB - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by micahcowan (Updated the item)
  • -email is unavailable- added by williamsiddall (Posted a comment)
  • -email is unavailable- added by None (Submitted the item)
  •  

    Follow 8 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2009-08-27 micahcowan StatusReady For Test Fixed
        Open/ClosedOpen Closed
    2009-07-06 micahcowan StatusNeeds Investigation Ready For Test
    2008-11-04 micahcowan Priority5 - Normal 4
    2008-05-01 micahcowan StatusNone Needs Investigation
    2007-09-21 micahcowan Work RequiredNone 0 - Hours
    2007-09-07 micahcowan Planned ReleaseNone 1.12
    2007-09-07 None Attached File- Added .listing, #13892

    Back to the top

    Powered by Savane 3.13-758e.
    Corresponding source code