taskGnash - The GNU Flash player - Tasks: task #7373, fix ActionScript 'super'...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

task #7373: fix ActionScript 'super' computation

Submitted by:  Sandro Santilli <strk>
Submitted on:  Wed 10 Oct 2007 05:53:28 PM UTC  
 
Should Start On:  Tue 09 Oct 2007 10:00:00 PM UTC Should be Finished on:  Tue 09 Oct 2007 10:00:00 PM UTC
Category:  None Priority:  7 - High
Status:  Done Privacy:  Public
Percent Complete:  100% Assigned to:  Sandro Santilli <strk>
Open/Closed:  Closed Effort:  0.00

( Jump to the original submission)

Thu 19 Jun 2008 02:20:24 PM UTC, comment #8:

all known super-related tests succeed now.
Cleanups would still be worth, as adding more tests seeking
for breaks.

Sandro Santilli <strk>
Project MemberIn charge of this item.
Tue 11 Mar 2008 08:51:32 PM UTC, comment #7:

Ok, was too entusiastic :)
We still have some version-specific issue in finding
a super from ActionCallMethod, where the method is found
some prototypes higher then just one level up.

test case: swfdec/super-missing-{7,8}.swf

Sandro Santilli <strk>
Project MemberIn charge of this item.
Tue 11 Mar 2008 09:00:56 AM UTC, comment #6:

I belive I'm done with this.
What's left may as well be considered a bug, so please hunt
for super bugs :)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Mon 10 Mar 2008 09:46:08 PM UTC, comment #5:

Attached is a patch that yelds 20 XPASS and 2 FAIL.
Fixes Kirupa_OOP_soldier_deconstruct.swf (file #13717 attached to bug #20832).
Fixes bug #22464.

Needs more cleanup, in particular in fetching the _proto_
member of as_object, this patch dropping support for the
visibility flag.

(file #15227)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 07 Mar 2008 04:05:27 PM UTC, comment #4:

Started a wiki page for the RE task:
http://wiki.gnashdev.org/wiki/index.php/ActionScriptSuper

Sandro Santilli <strk>
Project MemberIn charge of this item.
Fri 07 Mar 2008 12:32:35 PM UTC, comment #3:

Attached a test case that suggests the following:

1. Super is a special type of object bound to a constructor
and to a prototype
2. Calling this special object yeld a call to the associated
constructor
3. Fetching properties of this special object yeld properties
of the associated prototype
4. Association with the constructor and with the prototype
are set when the 'super' object is created, and cannot
be changed by ActionScript.

(file #15202, file #15203)

Sandro Santilli <strk>
Project MemberIn charge of this item.
Tue 16 Oct 2007 08:17:36 AM UTC, comment #2:

bug #21283 now contains another testcase:
a0652165c62594083f3f6b7b83765825 KeyCodes.swf
file #14146

Sandro Santilli <strk>
Project MemberIn charge of this item.
Thu 11 Oct 2007 08:03:56 PM UTC, comment #1:

Other testcase is bug #21283
http://www.autoprosoftware.co.uk/AM3%20Invoicing.swf
md5: c0316412d0f3bbd1356ac641d2e2f80f
SWF6

Sandro Santilli <strk>
Project MemberIn charge of this item.
Wed 10 Oct 2007 05:53:28 PM UTC, original submission:

Current Gnash implementation computes 'super' from 'this'.
This is not correct as if a constructor calls the upper class constructor, this will result in an infinite recursion.

We have an automated testcase for this in misc-mtasc.all (super_test1.swf) and a few bug items for external movies.

Known ones so far are:

SchedulerTour.swf
bug #21304
md5 b8906d802d2e2f2c2afff9d4a3df1cb4

AM3_Creating_Jobs.swf
bug #21295
md5 f00c703b495bc117a2b99e26c17b9d4c

Sandro Santilli <strk>
Project MemberIn charge of this item.

 

Attached Files
file #15227:  super.patch added by strk (17KiB - text/x-patch)
file #15202:  mx.as added by strk (5KiB - application/x-applix-spreadsheet)
file #15203:  mx.swf added by strk (1KiB - application/x-shockwave-flash)

 

Depends on the following items: None found

Digest:
   bug dependencies.

 

Carbon-Copy List
  • -email is unavailable- added by strk
  • -email is unavailable- added by strk (Submitted the item)
  • -email is unavailable- added by strk
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 14 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2008-07-12 strk Open/ClosedOpen => Closed
    2008-07-12 strk StatusReady For Test => Done
    2008-06-19 strk Percent Complete90% => 100%
    2008-03-11 strk Percent Complete100% => 90%
    2008-03-11 strk StatusIn Progress => Ready For Test
        Percent Complete50% => 100%
    2008-03-10 strk Attached File- => Added super.patch, #15227
        Priority5 - Normal => 7 - High
        StatusNone => In Progress
        Percent Complete0% => 50%
    2008-03-07 strk Attached File- => Added mx.as, #15202
        Attached File- => Added mx.swf, #15203
        Carbon-Copy- => Added zoulunkai
    2007-10-10 strk Carbon-Copy- => Added cmusick

    Back to the top


    Powered by Savane 3.3