mainGNU tar - Support: sr #109431, Process name not being preserved.

 
 

sr #109431: Process name not being preserved.

Submitter:  None
Submitted:  Mon 18 Dec 2017 09:45:30 PM UTC
   
 
Category:  None Priority:  5 - Normal
Severity:  3 - Normal Status:  None
Privacy:  Public Assigned to:  None
Originator Email:  -email is unavailable- Open/Closed:  Open
Operating System:  None
* Mandatory Fields

Add a New Comment Rich Markup
   

Mon 18 Dec 2017 09:45:30 PM UTC, original submission:  

While upgrading to GNU tar 1.30 on OmniOS (an illumos distribution) we noticed a couple of new test failures

Specifically:

175: remove-files with compression                   FAILED (remfiles01.at:32)
176: remove-files with compression: grand-child      FAILED (remfiles02.at:32)

Further investigation showed that these are failing because the command output does not include '(child)' or '(grandchild)' as expected.

This is due to the embedded gnulib update. Now gnu/error.c ends up calling getexecname() on this platform to retrieve the program name that is printed in error messages. In previous versions, the global program_name variable was used and this is what is populated by set_program_name() used to add (child)/(grandchild) to the program name when forking.

Our local patch is just to revert the behaviour as follows:

--- tar-1.30/gnu/error.c~     2017-12-18 19:21:42.707740963 +0000
+++ tar-1.30/gnu/error.c        2017-12-18 19:22:19.807927320 +0000
@@ -119,7 +119,7 @@
 #  endif
 # endif

-#define program_name getprogname ()
+extern char *program_name;

 # if GNULIB_STRERROR_R_POSIX || HAVE_STRERROR_R || defined strerror_r
 #  define __strerror_r strerror_r

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by None (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    No changes have been made to this item

    Back to the top

    Powered by Savane 3.13-4448.
    Corresponding source code