mainGnuTLS - Support: sr #108724, Configure option to avoid building...

 
 

sr #108724: Configure option to avoid building tools

Submitter:  Luke Dashjr <lukedashjr>
Submitted:  Sun 11 Jan 2015 01:22:51 PM UTC
   
 
Category:  Included programs Priority:  5 - Normal
Severity:  3 - Normal Status:  Done
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Operating System:  GNU/Linux
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Fri 16 Jan 2015 03:03:02 PM UTC, comment #15: 

Thanks, applied in master.

Nikos Mavrogiannopoulos <nmav>
Group administrator
Fri 16 Jan 2015 08:28:18 AM UTC, comment #14: 

I may have not been clear. I meant all the tests where two variables are used in combination. The "$enable_tools$enable_doc" != "nono" was an example.

Nikos Mavrogiannopoulos <nmav>
Group administrator
Thu 15 Jan 2015 09:15:25 PM UTC, comment #13: 

I just downloaded it from this page and it gave me the revised version. The only change was the "nono" you requested.

Luke Dashjr <lukedashjr>
Thu 15 Jan 2015 07:58:01 PM UTC, comment #12: 

The attached file is exactly the same as before.

Nikos Mavrogiannopoulos <nmav>
Group administrator
Thu 15 Jan 2015 12:34:59 AM UTC, comment #11: 

Doc examples use src/gl

(file #32826)

Luke Dashjr <lukedashjr>
Wed 14 Jan 2015 10:01:09 PM UTC, comment #10: 

I realized that there some conditional checks in the patch similar to:
if test "$enable_tools$enable_doc" != "no"
if test "$enable_tools$enable_doc" != "nono"

I find these quite confusing. Please resubmit a patch with clear such as:
if test "$enable_tools" != "no" && test "$enable_doc" != "no"

A question on the patch, is why do you do:
+if ENABLE_TOOLS
+SUBDIRS += src
+else
+SUBDIRS += src/gl
+endif
Why is the src/gl compiled if no tools are there?

Other than these the patch looks ok.

Nikos Mavrogiannopoulos <nmav>
Group administrator
Tue 13 Jan 2015 09:58:36 PM UTC, comment #9: 

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Luke Dashjr <lukedashjr>
Tue 13 Jan 2015 09:49:35 PM UTC, comment #8: 

No, I don't see anything in my mailbox or the archive.

Nikos Mavrogiannopoulos <nmav>
Group administrator
Mon 12 Jan 2015 11:40:12 PM UTC, comment #7: 

Spamhaus is unfortunately popular, so I am setup to easily evade it - did it not get through to the list?

Luke Dashjr <lukedashjr>
Mon 12 Jan 2015 11:29:02 PM UTC, comment #6: 

I have no control over it. Post it here, if it is better.

Nikos Mavrogiannopoulos <nmav>
Group administrator
Mon 12 Jan 2015 10:58:31 PM UTC, comment #5: 

Figured it out; sent.

P.S. I'd suggest disabling spamhaus.easydns.com on the mailing list server if possible, they are lately abusing their position to put political pressure against entire ISPs.

<gnutls-devel@lists.gnutls.org>: host mx.easymail.ca[205.210.42.59] said: 554
    5.7.1 Service unavailable; Client host [192.3.11.21] blocked using
    spamhaus.easydns.com; http://www.spamhaus.org/sbl/query/SBL240293 (in reply
    to RCPT TO command)

Luke Dashjr <lukedashjr>
Mon 12 Jan 2015 10:46:25 PM UTC, comment #4: 

DCO?

Luke Dashjr <lukedashjr>
Mon 12 Jan 2015 09:59:29 PM UTC, comment #3: 

Thanks. As it is quite an extensive patch, would you like to send the DCO to the list, as in http://www.gnutls.org/devel.html

Nikos Mavrogiannopoulos <nmav>
Group administrator
Mon 12 Jan 2015 07:34:59 PM UTC, comment #2: 

Attached patch.

Luke Dashjr <lukedashjr>
Mon 12 Jan 2015 09:55:34 AM UTC, comment #1: 

Feel free to provide a patch.

Nikos Mavrogiannopoulos <nmav>
Group administrator
Sun 11 Jan 2015 01:22:51 PM UTC, original submission:  

I would like to build gnutls without the included tools. Can a --disable-tools configure option be added? I can provide a patch, if necessary.

Luke Dashjr <lukedashjr>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #32840:  0001-Added-configure-option-disable-tools.patch added by lukedashjr (5KiB - text/x-patch - Patch: Added configure option --disable-tools)
file #32826:  0001-Added-configure-option-disable-tools.patch added by lukedashjr (4KiB - text/x-patch - Patch: Added configure option --disable-tools)
file #32812:  0001-Added-configure-option-disable-tools.patch added by None (4KiB - text/x-patch - Patch: Added configure option --disable-tools)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by nmav (Posted a comment)
  • -email is unavailable- added by lukedashjr (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 5 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-01-16 nmav StatusNone Done
        Open/ClosedOpen Closed
    2015-01-16 lukedashjr Attached File- Added 0001-Added-configure-option-disable-tools.patch, #32840
    2015-01-15 lukedashjr Attached File- Added 0001-Added-configure-option-disable-tools.patch, #32826
    2015-01-12 None Attached File- Added 0001-Added-configure-option-disable-tools.patch, #32812

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code