helpGnuTLS - Support: sr #108703, Windows build issues

 
 

sr #108703: Windows build issues

Submitted by:  Pierre Ossman <cendossm>
Submitted on:  Thu 11 Dec 2014 01:49:34 PM UTC  
 
Category:  Core library Priority:  5 - Normal
Severity:  3 - Normal Status:  None
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Operating System:  Microsoft Windows

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Sat 07 Mar 2015 10:45:06 PM UTC, comment #5: 

The issue tracker is being moved in gitlab; if the issue is not resolved in the latest gnutls version please open a ticket at:
https://gitlab.com/gnutls/gnutls/issues

Nikos Mavrogiannopoulos <nmav>
Project Administrator
Fri 12 Dec 2014 07:12:50 AM UTC, comment #4: 

About the fseek issue, I cannot see what is the issue, as we don't use the fseek module. So I cannot see why it has tried to override it, or test it at all. What I can suggest is to check gl/stdio.h and ask in the gnulib mailing list.

Nikos Mavrogiannopoulos <nmav>
Project Administrator
Thu 11 Dec 2014 06:35:47 PM UTC, comment #3: 

Regarding the fseek issue: if you can guide me how to disable the replacement, I might take a stub at providing a patch for that.  I'd rather we solved this problem, because otherwise the build is broken on Windows, and kludging around it without pulling back gnulib (which AFAIU is against your intentions) is not for the faint at heart.

(The rpl_close issue can be disregarded, since "make -k check" works around it, and 'close' is not replaced in the library, so no need to test the replacement.)

Thanks.

Eli Zaretskii <eliz>
Thu 11 Dec 2014 06:06:07 PM UTC, comment #2: 

I've applied Eli's patch unconditionally, select() seems to be available everywhere, as well as fixed for sleep() and certtool-cfg. For gnulib issues, I don't think I'd spend much time on it; if there are patches I'll apply them, otherwise I'd just skip them.

Nikos Mavrogiannopoulos <nmav>
Project Administrator
Thu 11 Dec 2014 05:12:46 PM UTC, comment #1: 

Indeed, I saw this as well (with MinGW32 and GnuTLS 3.3.10), and was about to report that.

Regarding fseek, I guess this is a license-related issue, in which case I think the easiest solution would be to not try to replace the Windows function (the issue which gnulib tries to solve is AFAIK not relevant to Windows).

For src/socket.c, I solved that with the patch in the attached; perhaps all other platforms could use that, in which case the cpp conditionals are not needed.

Other issues I've seen:

 . src/certtool-cfg.c triggers a compiler warning because of the 32-bit right shift of a 'long' variable

 . src/pkcs11.c calls 'sleep', which MinGW doesn't have

 . the gnulib tests in lib/gl fail because rpl_close is not available (similar to the fseek issue)

(file #32650)

Eli Zaretskii <eliz>
Thu 11 Dec 2014 01:49:34 PM UTC, original submission:  

Two issues:

 a) On at least Win64 we trigger the check for fseek/fseeko in gnulib. But fseek.c and fseeko.c aren't included so we get missing symbols at link time.

 b) src/socket.c uses alarm(), which doesn't exist on Windows. Some versions of mingw/mingw64 has it, but not all.

Tested with GnuTLS 3.3.11.

Pierre Ossman <cendossm>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #32650:  alarm.patch added by eliz (861B - application/octet-stream)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by nmav (Posted a comment)
  • -email is unavailable- added by eliz (Updated the item)
  • -email is unavailable- added by cendossm (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 2 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2015-03-07 nmav Open/ClosedOpen => Closed
    2014-12-11 eliz Attached File- => Added alarm.patch, #32650

    Back to the top


    Powered by Savane 3.7