mainGnash - The GNU Flash player - Support: sr #108015, Configuring with --enable-gui=fb...

 
 

sr #108015: Configuring with --enable-gui=fb and not --enable-device=rawfb results in build errors

Submitter:  Shoop da Whoop <sdw>
Submitted:  Thu 05 Apr 2012 10:53:10 PM UTC
   
 
Category:  None Priority:  5 - Normal
Severity:  3 - Normal Status:  Done
Privacy:  Public Assigned to:  rsavoye
Open/Closed:  Closed Operating System:  GNU/Linux
* Mandatory Fields

Add a New Comment Rich Markup
   

Jump to the original submission

Thu 12 Apr 2012 06:23:28 AM UTC, comment #6: 

Patch confirmed as working over here.  Thank you for your time.

Shoop da Whoop <sdw>
Wed 11 Apr 2012 03:45:53 PM UTC, comment #5: 

I don't see this as a bug, but I threw in an error message anyway. Configure can only do so much to work around being improperly configured, but I guess this was an easy one to trap. Fixed with #55ea6ac.

Rob Savoye <rsavoye>
Group administrator
Wed 11 Apr 2012 04:42:34 AM UTC, comment #4: 

If you are building gnash for the first time, it isn't obvious that trying to enable hardware acceleration for X will "bypass configure" and cause the build to fail.

My reason for building was to try out the non-default options, so taking the defaults isn't a solution in this case.

It would be more user-friendly if configure noticed the configuration conflict and stopped with an error message; since the build won't succeed, there isn't much point in continuing.

Instead, configure finishes with some warnings (e.g. no Ming installed), and then prints,
"Gnash should still compile even with these warnings.
If it doesn't, report the warnings as a bug."

Shoop da Whoop <sdw>
Tue 10 Apr 2012 01:50:26 PM UTC, comment #3: 

You bypassed configure by only specifying the x11 device. Personally, I always recommend people just use the defaults for configuring Gnash. Since you did specify --enable-device=x11, configure did what you wanted, so this isn't really a bug.

Rob Savoye <rsavoye>
Group administrator
Tue 10 Apr 2012 02:54:12 AM UTC, comment #2: 

Configured with: --disable-cygnal --disable-docbook --disable-plugins --disable-testsuite --enable-device=x11 --enable-fps-debug --enable-gui=fb,dump,gtk,qt4 --enable-media=gst,ffmpeg --enable-renderer=agg,cairo,opengl --program-suffix=-1 --without-gconf

or pretty close to that.  I think it's caused by the combination of --enable-gui= including fb and --enable-device= not including rawfb.

If --enable-device isn't set at all, the configure script keeps the values set earlier in response to the gui argument: build_rawfb_device=yes and device_list="RawFB".  But if --enable-device is set, the code clears those before processing the argument:

# Check whether --enable-device was given.
if test "${enable_device+set}" = set; then :
  enableval=$enable_device; enableval=`echo ${enableval} | tr '\054' ' ' `
  build_egl_device=no
  build_rawfb_device=no
  device_list=""
(etc)

and only goes by the argument to --enable-device.

./configure --enable-gui=fb --enable-device=x11 --without-gconf
was sufficient to cause the build error to occur again (--without-gconf only because I don't have the dependency installed.)

Shoop da Whoop <sdw>
Mon 09 Apr 2012 05:18:18 PM UTC, comment #1: 

I just tried configuring with --enable-gui=fb and not --enable-device=rawfb and the build worked just fine for me. What is the full line you used to configure ? Configure already has support to enable rawfb when the FB GUI is enabled.

Rob Savoye <rsavoye>
Group administrator
Thu 05 Apr 2012 10:53:10 PM UTC, original submission:  

Building the latest version - Gnash 0.8.11dev (master-21549-10d0e4e), checked out April 2nd, on Debian 6.0 squeeze/stable, on PowerPC architecture.

Trying to build with the fb gui enabled and no framebuffer device enabled, configure didn't complain about it, but compiling eventually errored out:

fb/fb_glue_agg.cpp: In member function ‘virtual bool gnash::gui::FBAggGlue::init(int, char***)’:
fb/fb_glue_agg.cpp:114: error: expected type-specifier
fb/fb_glue_agg.cpp:114: error: expected ‘)’
fb/fb_glue_agg.cpp:114: error: no matching function for call to ‘boost::scoped_ptr<gnash::renderer::GnashDevice>::reset(int*)’
/usr/include/boost/smart_ptr/scoped_ptr.hpp:83: note: candidates are: void boost::scoped_ptr<T>::reset(T*) [with T = gnash::renderer::GnashDevice]
fb/fb_glue_agg.cpp:117: error: ‘gnash::renderer::rawfb’ has not been declared
fb/fb_glue_agg.cpp:117: error: ‘rawfb’ was not declared in this scope
fb/fb_glue_agg.cpp:118: error: expected type-specifier
fb/fb_glue_agg.cpp:118: error: expected ‘>’
fb/fb_glue_agg.cpp:118: error: expected ‘(’
fb/fb_glue_agg.cpp:118: error: ‘gnash::renderer::rawfb’ has not been declared
fb/fb_glue_agg.cpp:118: error: expected primary-expression before ‘>’ token
fb/fb_glue_agg.cpp:118: error: expected ‘)’ before ‘;’ token
fb/fb_glue_agg.cpp: In member function ‘virtual gnash::Renderer* gnash::gui::FBAggGlue::createRenderHandler()’:
fb/fb_glue_agg.cpp:162: error: ‘gnash::renderer::rawfb’ has not been declared
fb/fb_glue_agg.cpp:162: error: ‘rawfb’ was not declared in this scope
fb/fb_glue_agg.cpp:163: error: expected type-specifier
fb/fb_glue_agg.cpp:163: error: expected ‘>’
fb/fb_glue_agg.cpp:163: error: expected ‘(’
fb/fb_glue_agg.cpp:163: error: ‘gnash::renderer::rawfb’ has not been declared
fb/fb_glue_agg.cpp:163: error: expected primary-expression before ‘>’ token
fb/fb_glue_agg.cpp:163: error: expected ‘)’ before ‘;’ token

Adding --enable-device=rawfb to the configuration options allowed compilation to succeed.

It seems to me that if this is a dependency, it ought to be caught by configure.

Shoop da Whoop <sdw>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by rsavoye (Updated the item)
  • -email is unavailable- added by sdw (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

    Only logged-in users can vote.

     

    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-04-12 rsavoye StatusReady For Test Done
        Open/ClosedOpen Closed
    2012-04-11 rsavoye StatusWorks For Me Ready For Test
    2012-04-10 rsavoye StatusNeed Info Works For Me
    2012-04-09 rsavoye StatusNone Need Info
        Assigned toNone rsavoye

    Back to the top

    Powered by Savane 3.13-02a9.
    Corresponding source code