helpGnuTLS - Support: sr #107983, lib/accelerated/x86/asm files...

 
 

sr #107983: lib/accelerated/x86/asm files incompatible with i386/x86_64 darwin

Submitted by:  Jack Howarth <jhowarth>
Submitted on:  Thu 15 Mar 2012 03:40:46 AM UTC  
 
Category:  Core library Priority:  5 - Normal
Severity:  3 - Normal Status:  Done
Privacy:  Public Assigned to:  Nikos Mavrogiannopoulos <nmav>
Open/Closed:  Closed Operating System:  Mac OS

Add a New Comment (Rich Markup)
   

You are not logged in

Please log in, so followups can be emailed to you.

 

Mon 02 Apr 2012 06:56:44 PM UTC, comment #2: 

This should be fixed in the latest releases.

Nikos Mavrogiannopoulos <nmav>
Project AdministratorIn charge of this item.
Thu 15 Mar 2012 05:49:01 PM UTC, comment #1: 

Hi, thank you for reporting the issue and the patch. These assembler files are automatically generated so I avoided any change on them and I generated them for MacOSX. Does the patch below solves the issue for you? (you might need to run autoreconf).

http://git.savannah.gnu.org/gitweb/?p=gnutls.git;a=commitdiff;h=080f43e1485e36addcaf4279a39848cf8b66a4df

Nikos Mavrogiannopoulos <nmav>
Project AdministratorIn charge of this item.
Thu 15 Mar 2012 03:40:46 AM UTC, original submission:  

The current gnutls 3.0.15 release contains assembly files in lib/accelerated/x86/asm which are incompatible with i386/x86_64 darwin. Minimal changes are required for these to properly compile on darwin...

1) Use the more portable .balign rather than .align (since i386/x86_64 darwin doesn't support .align > 15).
2) Add underscore to global symbols (as well as _aesni_set_encrypt_key and calls to it) using SYM macro.
3) Add TYPEF/TYPEO and SIZE macros to handle .type for @function/@object and .size on darwin as is done in the FSF gcc libitm assembly files.
4) Add and :"#ifdef _linux_" on ".section .note.GNU-stack,"",%progbits"

With these change the accelerated assembly code is compiled at i386 and x86_64 on darwin10/11 and the resulting build passes the gnutls test suite.

Jack Howarth <jhowarth>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #25366:  gnutls_darwin.patch added by jhowarth (55KiB - application/octet-stream - darwin lib/accelerated/x86/asm assembly changes)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by nmav (Posted a comment)
  • -email is unavailable- added by jhowarth (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

     

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2012-04-02 nmav StatusNone => Done
        Assigned toNone => nmav
        Open/ClosedOpen => Closed
    2012-03-15 jhowarth Attached File- => Added gnutls_darwin.patch, #25366

    Back to the top


    Powered by Savane 3.7