PSPP - Patches: patch #6210, Make viewport {width, length}...
You are not allowed to post comments on this tracker with your current authentication level.
patch #6210: Make viewport {width, length} under direct ownership of the user interface
Submitter: | John Darrington <jmd> | ||
Submitted: | Wed 19 Sep 2007 02:32:32 AM UTC | ||
Category: | None | Item Group: | None |
Status: | Done | Assigned to: | blp |
Open/Closed: | Closed |
Jump to the original submission
Wed 26 Sep 2007 04:27:53 AM UTC, comment #16: |
Ben Pfaff <blp> |
Wed 26 Sep 2007 12:09:05 AM UTC, comment #15: OK. I've committed this. So far as I can tell, that just leaves file #14025 to be committed. I'll let you do this then I think we can close this item. |
John Darrington <jmd> |
Tue 25 Sep 2007 02:19:03 PM UTC, comment #14:
|
Ben Pfaff <blp> |
Tue 25 Sep 2007 06:27:37 AM UTC, comment #13: It looks good.
|
John Darrington <jmd> |
Tue 25 Sep 2007 04:43:51 AM UTC, comment #12:
|
Ben Pfaff <blp> |
Tue 25 Sep 2007 04:01:22 AM UTC, comment #11: OK. Thanks for the explanation.
|
John Darrington <jmd> |
Tue 25 Sep 2007 03:50:42 AM UTC, comment #10:
|
Ben Pfaff <blp> |
Tue 25 Sep 2007 01:10:45 AM UTC, comment #9: Everything looks fine to me, except that I'm confused by the code:
|
John Darrington <jmd> |
Mon 24 Sep 2007 01:45:38 AM UTC, comment #8: These two are fine:
|
John Darrington <jmd> |
Mon 24 Sep 2007 12:32:32 AM UTC, comment #7: OK, here's a series of patches that should apply on top of yours. In order:
|
Ben Pfaff <blp> |
Wed 19 Sep 2007 04:56:19 AM UTC, comment #6:
|
Ben Pfaff <blp> |
Wed 19 Sep 2007 04:52:37 AM UTC, comment #5: Ben wrote:
|
John Darrington <jmd> |
Wed 19 Sep 2007 04:22:31 AM UTC, comment #4: John wrote:
|
Ben Pfaff <blp> |
Wed 19 Sep 2007 03:54:15 AM UTC, comment #3:
|
John Darrington <jmd> |
Wed 19 Sep 2007 03:33:55 AM UTC, comment #2:
|
Ben Pfaff <blp> |
Wed 19 Sep 2007 03:31:17 AM UTC, comment #1: I think that the new version of get_termcap_viewport calls set_fallback_viewport unconditionally, not just when tgetnum fails to return good values.
|
Ben Pfaff <blp> |
Wed 19 Sep 2007 02:32:32 AM UTC, original submission:
This patch solves half the problem. I've moved get_termcap_viewport to src/ui/terminal/main.c, made it a handler for SIGWINCH, and done the equivalent work in the GUI.
|
John Darrington <jmd> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 9 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2007-09-26 | blp | Status | Ready For Test/Review | Done | |
Open/Closed | Open | Closed | |||
2007-09-25 | jmd | Attached File | - | Added viewport-gui.patch, #14026 | |
2007-09-25 | blp | Attached File | - | Added viewport-happy-signal-handler-2.patch, #14025 | |
2007-09-24 | blp | Attached File | - | Added viewport-fallback-obviousness.patch, #14016 | |
Attached File | - | Added viewport-dont-call-it-a-script.patch, #14017 | |||
Attached File | - | Added viewport-drop-long-view.patch, #14018 | |||
Attached File | - | Added viewport-happy-signal-handler.patch, #14019 | |||
2007-09-19 | jmd | Attached File | - | Added viewport.patch, #13986 |
Powered by Savane 3.13-f8d8.
Corresponding source code
Done, on both counts.