GNU nano - Patches: patch #8182, Improve strange scrolling...
You are not allowed to post comments on this tracker with your current authentication level.
patch #8182: Improve strange scrolling behaviour when softwrap is on.
Submitter: | Benno Schulenberg <bens> | ||
Submitted: | Sat 14 Sep 2013 03:28:22 PM UTC | ||
Priority: | 5 - Normal | Status: | Done |
Privacy: | Public | Assigned to: | bens |
Open/Closed: | Closed | Release: | None |
Jump to the original submission
Wed 26 Mar 2014 09:51:48 AM UTC, comment #6: |
Benno Schulenberg <bens> |
Mon 03 Mar 2014 12:53:41 PM UTC, comment #5: Attached patch has gone into SVN; I believe this is the fully correct computation. Some of the surrounding code can probably be simplified or removed, because 'onlastline' is not determined correctly, and 'openfile->current_y == editwinrows - 1' is only ever true when 'amount' is bigger than zero (well, in softwrap mode, that is).
|
Benno Schulenberg <bens> |
Sun 02 Mar 2014 05:18:39 PM UTC, comment #4: Okay, this new patch should fix it. In retrospect it kind of reproduces the extracuzsoft computation in winio.c, but in a way that I can understand it: without using this maxrow thing. It can probably be simplified, but for now it will do. |
Benno Schulenberg <bens> |
Fri 28 Feb 2014 09:52:05 AM UTC, comment #3: It's still not entirely fixed. Do an 'stty rows 25 cols 80' and then open the attached example file with 'nano -$'. Do a PageDown, and then do CursorDowns until reaching the "second overlong line" -- it doesn't scroll fully into view. One more CursorDown, and also the third overlong line only becomes partly visible. Another CursorDown, and the screen jumps half a page. |
Benno Schulenberg <bens> |
Mon 16 Sep 2013 07:48:17 PM UTC, comment #2: Okay, am attaching a better patch. With this patch, I can't find any jumpy or unexpected scrolling behaviour any more. It also fixes the non-showing last line reported in comment #1 of bug #27550 (https://savannah.gnu.org/bugs/?27550). |
Benno Schulenberg <bens> |
Sun 15 Sep 2013 04:15:28 PM UTC, comment #1: Neh... Not fixed entirely. When walking not all the way back to the top, but just one line short, leaving one line of "ho ho ho" visible, and then walking down again, reaching the first "ho" does not scroll both missing lines into view but only one.
|
Benno Schulenberg <bens> |
Sat 14 Sep 2013 03:28:22 PM UTC, original submission:
When softwrap is enabled and there is an overlong line in the file, walking up and down through it results in unexpected scrolling behaviour. To reproduce this, first create a test file that is adapted to your terminal size:
|
Benno Schulenberg <bens> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 13 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2014-03-26 | bens | Status | In Progress | Done | |
Open/Closed | Open | Closed | |||
2014-03-03 | bens | Attached File | - | Added nano--fix-the-softwrap-scrolling.patch, #30757 | |
2014-03-02 | bens | Attached File | - | Added nanana--scrolling.patch, #30752 | |
2014-02-28 | bens | Attached File | - | Added overlong.text, #30733 | |
Status | Done | In Progress | |||
Open/Closed | Closed | Open | |||
Summary | Solve strange scrolling behaviour when softwrap is on. | Improve strange scrolling behaviour when softwrap is on. | |||
2014-02-26 | bens | Status | None | Done | |
Assigned to | None | bens | |||
Open/Closed | Open | Closed | |||
2013-09-16 | bens | Attached File | - | Added scroll-when-on-overlong-line.patch, #29152 | |
2013-09-14 | bens | Attached File | - | Added recalculate-usable-rows-often.patch, #29136 |
Powered by Savane 3.13-3230.
Corresponding source code
Should be fully fixed after r4643, three weeks ago.