Gnash - The GNU Flash player - Patches: patch #8086, RTMP netStream patch
You are not allowed to post comments on this tracker with your current authentication level.
patch #8086: RTMP netStream patch
Submitter: | George Thomas <georgethomas> | ||
Submitted: | Fri 21 Jun 2013 04:22:06 PM UTC | ||
Category: | core | Priority: | 2 |
Status: | Done | Privacy: | Public |
Assigned to: | georgethomas | Open/Closed: | Closed |
Jump to the original submission
Sat 14 Sep 2013 08:15:33 AM UTC, comment #43: |
Sandro Santilli <strk> |
Sat 14 Sep 2013 06:27:02 AM UTC, comment #42: Created a pull request in your branch for the the updates. As you mentioned, I removed the access to rtmp from NetStream and moved it to getStream in Netconnection.
|
George Thomas <georgethomas> |
Fri 06 Sep 2013 02:16:19 PM UTC, comment #41: I think the place you can access NetConnection._rtmp is NetConnection_as::getStream. It's just a matter of getting all required argument, if the resource name is not enough.
|
Sandro Santilli <strk> |
Fri 06 Sep 2013 01:55:03 PM UTC, comment #40: This logically looks like a mistake but I am also surprised it is working.
|
George Thomas <georgethomas> |
Fri 06 Sep 2013 11:41:57 AM UTC, comment #39: I also have to admit I don't understand the rtmp::RTMP class, how does simply defining an instance of that class (with no parameters to the constructor) and calling .call(buf) on it know where to send the data ?
|
Sandro Santilli <strk> |
Fri 06 Sep 2013 11:39:31 AM UTC, comment #38: Things could be moved incrementally.
|
Sandro Santilli <strk> |
Fri 06 Sep 2013 11:30:00 AM UTC, comment #37:
|
George Thomas <georgethomas> |
Thu 05 Sep 2013 12:07:41 PM UTC, comment #36: My idea was to have StreamProvider support RTMP directly, having an RTMP-based subclass of IOChannel. I haven't really looked at your code to see how close your approach is to that.
|
Sandro Santilli <strk> |
Thu 05 Sep 2013 11:32:22 AM UTC, comment #35:
It may even be possible to use the same test, extending it, only problem is that the RTMP part should only run when activated..
|
George Thomas <georgethomas> |
Thu 05 Sep 2013 11:04:20 AM UTC, comment #34: Perfect, patch committed to the branch.
|
Sandro Santilli <strk> |
Thu 05 Sep 2013 10:39:50 AM UTC, comment #33: Shifted the testcase to use square.flv and it is working fine for me with gnashdev. Also modified the testcase to get invokesd as per onMetaData rather than onStatus.
|
George Thomas <georgethomas> |
Wed 04 Sep 2013 10:15:00 PM UTC, comment #32:
|
Gabriele Giacone <gg0> |
Wed 04 Sep 2013 09:41:26 PM UTC, comment #31: FYI: I've pushed the patches so far on a github branch
|
Sandro Santilli <strk> |
Wed 04 Sep 2013 08:43:18 PM UTC, comment #30: Consider looking at http://code.google.com/p/flvmeta/
|
Sandro Santilli <strk> |
Wed 04 Sep 2013 05:47:11 PM UTC, comment #29: Thank you :)
|
George Thomas <georgethomas> |
Wed 04 Sep 2013 05:26:02 PM UTC, comment #28: The .flv files listed below do all exist in the Red5 installation on gnashdev.org. |
Rob Savoye <rsavoye> |
Wed 04 Sep 2013 01:08:20 PM UTC, comment #27: All failures on make check (for the record):
|
Sandro Santilli <strk> |
Wed 04 Sep 2013 11:23:14 AM UTC, comment #26: Besides, I just wanted to mention that with your patch gnash is able to play the stream, that's very good ! :)
|
Sandro Santilli <strk> |
Wed 04 Sep 2013 11:15:36 AM UTC, comment #25: The test passes with the proprietary player here (now that I'm on a good connection).
|
Sandro Santilli <strk> |
Wed 04 Sep 2013 09:39:53 AM UTC, comment #24: I have updateded the patch to use spaces only and done some changes to some of the contents. Patch(oflaDemo.patch) attached. |
George Thomas <georgethomas> |
Tue 03 Sep 2013 03:49:32 PM UTC, comment #23: currentFps doesn't return "true", but you're checking for !currentFps, which evidently evaluates to true (currentFps is indeed 0 here). About version, can't you try using the online host ?
|
Sandro Santilli <strk> |
Tue 03 Sep 2013 01:44:14 PM UTC, comment #22: The Xfail could be an issue with the server version as well. The currentfps property should not be returning true as it makes no sense to me.
|
George Thomas <georgethomas> |
Tue 03 Sep 2013 01:15:58 PM UTC, comment #21: Using buffer.Full should work but when videos are streamed, is it compulsory that buffer would become full for all the videos? I could think of situation where the contents of the buffer are always consumed that it will never get full. In case of streaming is that case unlikely ?
|
George Thomas <georgethomas> |
Tue 03 Sep 2013 12:48:23 PM UTC, comment #20: I still get an XFAILED with the PP 10,0,12,10 LNX
|
Sandro Santilli <strk> |
Tue 03 Sep 2013 11:24:07 AM UTC, comment #19: Attaching a newer version of my patch which works for proprietry player.
|
George Thomas <georgethomas> |
Tue 03 Sep 2013 10:26:58 AM UTC, comment #18:
|
Gabriele Giacone <gg0> |
Tue 03 Sep 2013 09:52:55 AM UTC, comment #17: Rob, can you take care of this ? Or does anyone else have access to the machine ? |
Sandro Santilli <strk> |
Mon 02 Sep 2013 06:11:33 PM UTC, comment #16: Sorry I was using the localhost version of the oflaDemo for the test till now. So guess that was the buffer got full so fast :)
|
George Thomas <georgethomas> |
Mon 02 Sep 2013 04:47:11 PM UTC, comment #15: Uhm, the test never completes for me, I guess it never gets a Buffer.Full event ?
|
Sandro Santilli <strk> |
Mon 02 Sep 2013 03:58:24 PM UTC, comment #14: I used a check for event code "NetStream.Buffer.Full" and it is working for me without issues. I have attached a patch with the change. |
George Thomas <georgethomas> |
Mon 02 Sep 2013 02:50:24 PM UTC, comment #13: It may very well be a time-related issue, as I'm on a slow network right now. Any chance to remove the time dependent component from the test ? Like, is there any event that NetStream should be sending when data starts getting down ? |
Sandro Santilli <strk> |
Mon 02 Sep 2013 02:38:29 PM UTC, comment #12: I tried the testcase using the flah player and did not recieve any failures.
|
George Thomas <georgethomas> |
Mon 02 Sep 2013 01:47:36 PM UTC, comment #11: I see those tests look weird, maybe there are typos ?
|
Sandro Santilli <strk> |
Mon 02 Sep 2013 01:31:11 PM UTC, comment #10: I still get 4 failures with the proprietary player:
|
Sandro Santilli <strk> |
Tue 27 Aug 2013 07:41:26 AM UTC, comment #9: Is this patch good to go or are there any issues ? |
George Thomas <georgethomas> |
Mon 12 Aug 2013 08:20:47 AM UTC, comment #8: Adding a new version(rtmpnew.patch) of the rtmp patch wwith test cases updated.
|
George Thomas <georgethomas> |
Wed 31 Jul 2013 03:27:13 PM UTC, comment #7:
|
Gabriele Giacone <gg0> |
Wed 31 Jul 2013 11:52:16 AM UTC, comment #6: Ran the regressing with the source checked out today. Could not find any regressions when tested with and without rtmp2.patch
|
George Thomas <georgethomas> |
Thu 11 Jul 2013 07:39:28 AM UTC, comment #5: Please make sure you have an up-to-date snapshot of gnash, as we recently fixed the testsuite. |
Sandro Santilli <strk> |
Thu 11 Jul 2013 06:35:25 AM UTC, comment #4: I ran the testsuite and found some changes and most of the FAIL's and XPASS's don't seem to be related to this patch.
|
George Thomas <georgethomas> |
Thu 11 Jul 2013 06:06:17 AM UTC, comment #3: The propereitry player does not give any sound. In Gnash the sound comes because in NetStream_as.cpp there is a line like this in the play function.
|
George Thomas <georgethomas> |
Fri 05 Jul 2013 05:51:13 PM UTC, comment #2: Attaching another version of the .as file making use of the RED5_HOST Makefile variable.
|
Sandro Santilli <strk> |
Tue 25 Jun 2013 10:28:13 AM UTC, comment #1: George, do you run the full testsuite ? Most of it requires to have libming installed, and there other other dependencies to run other portions of it. The more you have the more tests you'll be able to prove your patch against. The ./configure invocation should give you WARNING lines for missing test dependencies.
|
Sandro Santilli <strk> |
Fri 21 Jun 2013 04:22:06 PM UTC, original submission:
The patch enabled the streaming of rtmp video when the oflaDemo.swf was run using gnash. oflaDemo.as is the testcase which made use of the oflaDemo plugin in red5 as the server.
|
George Thomas <georgethomas> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 16 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2013-09-14 | strk | Status | In Progress | Done | |
Open/Closed | Open | Closed | |||
2013-09-14 | georgethomas | Attached File | - | Added rtmp.patch, #29131 | |
2013-09-05 | georgethomas | Attached File | - | Added branch.patch, #29011 | |
2013-09-04 | georgethomas | Attached File | - | Added oflaDemo.patch, #29006 | |
2013-09-04 | georgethomas | Attached File | - | Added oflaDemo.patch, #29004 | |
2013-09-03 | georgethomas | Attached File | - | Added event.patch, #28990 | |
2013-09-03 | strk | Carbon-Copy | - | Added -email is unavailable- | |
2013-09-02 | georgethomas | Attached File | - | Added hobbit_vp6.flv.meta, #28980 | |
2013-09-02 | georgethomas | Attached File | - | Added event.patch, #28979 | |
2013-09-02 | strk | Status | Works For Me | In Progress | |
2013-08-23 | georgethomas | Status | Done | Works For Me | |
2013-08-12 | georgethomas | Attached File | - | Added rtmpnew.patch, #28816 | |
2013-07-11 | georgethomas | Attached File | - | Added result.log, #28537 | |
2013-07-05 | strk | Attached File | - | Added rtmp2.patch, #28489 | |
2013-06-21 | georgethomas | Attached File | - | Added rtmp.patch, #28378 |
Powered by Savane 3.13-3230.
Corresponding source code
Patch and subsequent pull requests + few tweaks of mine all squashed and pushed in master as this:
http://git.savannah.gnu.org/cgit/gnash.git/commit/?id=f246e38aa4723afe397b23f52b489391a17419b5