patchGNU Autoconf Archive - Patches: patch #7511, Remove comment from code snippet...

 
 

patch #7511: Remove comment from code snippet in ax_have_qt.m4

Submitter:  None
Submitted:  Wed 23 Mar 2011 04:02:56 PM UTC
   
 
Priority:  5 - Normal Status:  Done
Assigned to:  simons Originator Email:  -email is unavailable-
Open/Closed:  Closed
* Mandatory Fields

Add a New Comment Rich Markup
   

Wed 06 Apr 2011 01:07:30 PM UTC, comment #3: 

The updated patch has been pushed to the repository in commit e4871a21b1be5ec91f76bd8737570e63603f1c10. Thank you very much!

Peter Simons <simons>
Group administrator
Fri 01 Apr 2011 05:20:37 PM UTC, comment #2: 

I see Philipp has agreed on the mailing list, so I assume it's okay to close this item.

Peter Simons <simons>
Group administrator
Tue 29 Mar 2011 08:25:25 AM UTC, comment #1: 

That doesn't sound ideal to me.  More likely, autoconf elides an else branch if the corresponding macro argument consists entirely of white space.  I'd rather make it a proper shell statement, for example:

  : # Leave ax_qt_lib_dir defined.

Ralf Wildenhues <rwild>
Wed 23 Mar 2011 04:02:56 PM UTC, original submission:  

Newer autoconfs choke on code snippets that only have comments so remove it

Anonymous

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #22998:  autoconf-archive-fix_AX_HAVE_QT.patch added by None (616B - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by simons (Original author of the macro)
  • -email is unavailable- added by simons (Posted a comment)
  • -email is unavailable- added by rwild (Posted a comment)
  •  

    Follow 10 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2011-04-12 simons StatusReady For Test Done
        Open/ClosedOpen Closed
    2011-04-06 simons StatusInvalid Ready For Test
        Assigned toNone simons
        Open/ClosedClosed Open
        SummaryRemoe comment form code snippet in ax_have_qt.m4 Remove comment from code snippet in ax_have_qt.m4
        Carbon-Copy- Added bastiaan veelo <bastiaan@veelo.net>
    2011-04-01 simons StatusNone Invalid
        Open/ClosedOpen Closed
    2011-03-23 None Attached File- Added autoconf-archive-fix_AX_HAVE_QT.patch, #22998

    Back to the top

    Powered by Savane 3.13-bb6a.
    Corresponding source code