patchPSPP - Patches: patch #5244, Clean up DATA LIST and PRINT

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5244: Clean up DATA LIST and PRINT

Submitted by:  Ben Pfaff <blp>
Submitted on:  Mon 17 Jul 2006 04:15:50 AM UTC  
 
Category:  None Item Group:  None
Status:  Done Assigned to:  None
Open/Closed:  Closed

Tue 18 Jul 2006 04:57:23 AM UTC, comment #5: 

Checked in.

Ben Pfaff <blp>
Project Administrator
Tue 18 Jul 2006 01:16:55 AM UTC, comment #4: 

> I'm happy for this to be checked in as is. So long as we bear in mind that
> the messaging may need to be revisited at some time in the future.


Yes, I understand, and that's fine.

I'll check it in soon.

Ben Pfaff <blp>
Project Administrator
Tue 18 Jul 2006 12:40:23 AM UTC, comment #3: 

I'm happy for this to be checked in as is.  So long as we bear in mind that the messaging may need to be revisited at some time in the future.

John Darrington <jmd>
Project Administrator
Mon 17 Jul 2006 02:23:55 PM UTC, comment #2: 

> I'm still not 100% happy with the way that messages are handled. I think it'll
> be necessary to have a system that can selectively disable messages, based on
> message ID and destination.


Well, there's what I intend msg_disable/msg_enable to be used for, which is to disable messages from specific functions as an alternative to passing in a "emit_messages" flag to that function, and then there's what it can be used for, which is to disable any message anytime.  I like having them for the former purpose, because it's inconvenient to write those functions so that they check the flag before emitting any message, and most callers do want the messages in practice.

I'm not trying to preempt a broader discussion with this patch.  If you like, I'll prepare a new version that avoids adding msg_disable/msg_enable in favor of passing flags, and then we can bring up the broader discussion again.

Ben Pfaff <blp>
Project Administrator
Mon 17 Jul 2006 10:52:29 AM UTC, comment #1: 

Seems fine to me.

I'm still not 100% happy with the way that messages are handled. I think it'll be necessary to have a system that can selectively disable messages, based on message ID and destination.  But I guess that's not what this patch is really about.

John Darrington <jmd>
Project Administrator
Mon 17 Jul 2006 04:15:50 AM UTC, original submission:  

This patch cleans up DATA LIST and PRINT in preparation for re-implementing REPEATING DATA (bug #12859).   It reduces the code duplication between DATA LIST and PRINT a great deal, actually reducing the total code in PSPP by a couple hundred lines.  The result should be more maintainable as well as easier to read.

(This couples nicely with another patch I should integrate afterward, for cleaning up the handling of variable formats.)

Comments?

Ben Pfaff <blp>
Project Administrator

 

Attached Files
file #10367:  data-list.patch added by blp (121KiB - application/octet-stream - DATA LIST, PRINT cleanup patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

Do you think this task is very important?
If so, you can add your encouragement to it.
This task has 0 encouragements so far.

Only logged-in users can vote.

 

 

 

Follow 3 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-07-18 blp StatusReady For Test/Review => Done
    Open/ClosedOpen => Closed
2006-07-17 blp Attached File- => Added data-list.patch, #10367

Back to the top


Powered by Savane 3.5