patchPSPP - Patches: patch #5225, Assertions

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #5225: Assertions

Submitter:  John Darrington <jmd>
Submitted:  Tue 04 Jul 2006 06:36:42 AM UTC
   
 
Category:  None Item Group:  None
Status:  Done Assigned to:  blp
Open/Closed:  Closed

Sat 08 Jul 2006 03:06:53 AM UTC, comment #4: 

Committed to CVS.

Ben Pfaff <blp>
Group administrator
Wed 05 Jul 2006 03:40:08 PM UTC, comment #3: 


> OK.
>
> I'm happy with that.


Whew.  Glad to hear it.  For some reason, or perhaps it's irrational, I do not want to change "assert" to something else.

Unless I hear from you (or Jason) otherwise, I'll check this in within a day or two.

> I think it's still appropriate to use g_assert and g_not_reached for the gui
> specific code.


That is fine with me.

Ben Pfaff <blp>
Group administrator
Wed 05 Jul 2006 10:55:20 AM UTC, comment #2: 

OK.

I'm happy with that. 

I think it's  still appropriate to use g_assert and g_not_reached for the gui specific code.

J'

John Darrington <jmd>
Group administrator
Wed 05 Jul 2006 05:05:41 AM UTC, comment #1: 

I want to offer a counter-proposal.  The big advantage of this patch set is, IMO, that there is no need to change from using assert to using something else.  It does add a NOT_REACHED macro for use in place of assert (0).

Patch attached.

Ben Pfaff <blp>
Group administrator
Tue 04 Jul 2006 06:36:42 AM UTC, original submission:  

We talked about this, but didn't get around to doing anything.

It's a simple change, but a rather pervasive one.

John Darrington <jmd>
Group administrator

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #10306:  counterproposal.patch added by blp (56KiB - application/octet-stream - patch offered by blp as counterproposal)
file #10299:  assert.patch added by jmd (205KiB - text/x-patch)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2006-07-08 blp StatusReady For Test/Review Done
    Open/ClosedOpen Closed
2006-07-05 blp Attached File- Added counterproposal.patch, #10306
2006-07-04 jmd Attached File- Added assert.patch, #10299

Back to the top

Powered by Savane 3.13-02a9.
Corresponding source code