PSPP - Patches: patch #5209, Proposed casefile changes
You are not allowed to post comments on this tracker with your current authentication level.
patch #5209: Proposed casefile changes
Submitter: | John Darrington <jmd> | ||
Submitted: | Wed 28 Jun 2006 12:03:08 PM UTC | ||
Category: | None | Item Group: | None |
Status: | Done | Assigned to: | None |
Open/Closed: | Closed |
Jump to the original submission
Mon 17 Jul 2006 10:49:06 AM UTC, comment #13: |
John Darrington <jmd> |
Mon 17 Jul 2006 04:19:33 AM UTC, comment #12: I'm happy to see this version of the patch checked in.
|
Ben Pfaff <blp> |
Mon 17 Jul 2006 01:14:14 AM UTC, comment #11: Oops.
|
John Darrington <jmd> |
Sun 16 Jul 2006 08:45:20 PM UTC, comment #10:
|
Ben Pfaff <blp> |
Sat 15 Jul 2006 12:04:15 PM UTC, comment #9: Round 3.
|
John Darrington <jmd> |
Sat 15 Jul 2006 03:52:02 AM UTC, comment #8:
|
Ben Pfaff <blp> |
Sat 15 Jul 2006 03:33:49 AM UTC, comment #7: Do you think it would be a good idea to factor out the _xfer functions? Ie, casefile.c can do the ownership transfer, so that implementations don't need to provide a _xfer versions of their own? I expect it'll make implementations easier and less error prone. |
John Darrington <jmd> |
Thu 13 Jul 2006 11:01:34 PM UTC, comment #6: No worries. I'll work on it some more and send it back for another round shortly.
|
John Darrington <jmd> |
Thu 13 Jul 2006 05:37:41 AM UTC, comment #5: The second patch you posted is closer to what I had in mind, but I
projects use that spelling a lot, but "class" works just fine in C.
anyway a few lines later, and they make the code harder to read.
perhaps a little safer, but I don't think it's enough to be really
and there's not really a good reason to embed them with a separate
|
Ben Pfaff <blp> |
Wed 12 Jul 2006 01:55:35 AM UTC, comment #4: I haven't read the code yet, but here are my thoughts on the questions you bring up.
|
Ben Pfaff <blp> |
Tue 11 Jul 2006 09:07:11 AM UTC, comment #3: Here's the second revision. It's probably still in need of work.
|
John Darrington <jmd> |
Tue 04 Jul 2006 05:20:57 AM UTC, comment #2: Handing back to John. |
Ben Pfaff <blp> |
Wed 28 Jun 2006 06:15:32 PM UTC, comment #1:
|
Ben Pfaff <blp> |
Wed 28 Jun 2006 12:03:08 PM UTC, original submission:
|
John Darrington <jmd> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 18 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2006-07-17 | jmd | Status | Works For Me | Done | |
Assigned to | jmd | None | |||
Open/Closed | Open | Closed | |||
2006-07-17 | blp | Status | Ready For Test/Review | Works For Me | |
Assigned to | blp | jmd | |||
2006-07-17 | jmd | Assigned to | jmd | blp | |
Attached File | - | Added xx.patch, #10366 | |||
2006-07-16 | blp | Assigned to | blp | jmd | |
2006-07-15 | jmd | Status | In Progress | Ready For Test/Review | |
Assigned to | jmd | blp | |||
Attached File | - | Added casefile-3.patch, #10360 | |||
2006-07-13 | blp | Assigned to | blp | jmd | |
Attached File | - | Added alternative.patch, #10341 | |||
2006-07-11 | jmd | Status | None | In Progress | |
Assigned to | jmd | blp | |||
Attached File | - | Added casefile-patch2, #10329 | |||
2006-07-04 | blp | Assigned to | blp | jmd | |
2006-06-28 | jmd | Attached File | - | Added patch, #10261 |
Powered by Savane 3.13-d3ae.
Corresponding source code
Patch checked in.