patchphpGroupWare - Patches: patch #4478, fix for password reminder

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4478: fix for password reminder

Submitter:  Sigurd Nes <sigurdne>
Submitted:  Thu 29 Sep 2005 02:05:33 PM UTC
   
 
Category:  API - phpGWapi Priority:  5 - Normal
Item Group:  0.9.16 (stable) Status:  Done
Privacy:  Public Assigned to:  Caeies
Open/Closed:  Closed

Jump to the original submission

Tue 04 Oct 2005 07:52:24 AM UTC, comment #7: 

Ok,

Commited in CVS.

Regards,

Caeies

Caeies <Caeies>
Group administrator
Fri 30 Sep 2005 06:58:04 PM UTC, comment #6: 

Here is the patch rebuilt with  test_changepassword.txt. I don't know about the ^M. I built the patch in a cygwin environment - and saved it as an UNIX-file with textpad.
the patch works fine for me with the command: 'patch -p0 < password_reminder.diff'

Regards

Sigurd

Sigurd Nes <sigurdne>
Group Member
Fri 30 Sep 2005 05:16:12 PM UTC, comment #5: 

Ok for this one It's ok for me

So can you rebuild your patch with test_changepassword.txt + password_reminder.diff and without ^M ?

If nobody complains, I will commit it Sunday if I have time.

Regards,

Caeies

Caeies <Caeies>
Group administrator
Fri 30 Sep 2005 05:00:19 PM UTC, comment #4: 

How about this one - testing for the acl-right 'changepassword' at location 'preferences'?
(see attached test_changepassword.txt)

Regards

Sigurd

Sigurd Nes <sigurdne>
Group Member
Fri 30 Sep 2005 04:04:24 PM UTC, comment #3: 

I confirm that it's a bug from ldap (Lastpaswdchange is not set. Will be in CVS in a few moment.

And it's working in this case ... So looks good for me (just the problem from people not allowed to change their password).

I can't really test with sql auth since I don't have a fully running app using sql.

So please don't add the if( == sql) that's a kind of non sense :).

So If nobody consider this as a new feature, I will commit it in 2 or 3 days...

Regards

Caeies

Caeies <Caeies>
Group administrator
Fri 30 Sep 2005 02:19:27 PM UTC, comment #2: 

How about test for account_repository = sql? (as attached in file)

Sigurd Nes <sigurdne>
Group Member
Fri 30 Sep 2005 12:37:27 PM UTC, comment #1: 

Hi all,

It doesn't seems to work for me ... some remarks :
 - the whole things shouldn't appear in case of the user has no right to change his password ...
 - Then, it seems that even if just changed, this doesn't work in the case of LDAP (that's perhaps a problem with the ldap backend, but I don't have time to look at it right now).

So need some rework. And please, be carefull with ^M in files :)

Regards,

Caeies

Caeies <Caeies>
Group administrator
Thu 29 Sep 2005 02:05:33 PM UTC, original submission:  

The password reminder seems not to be working - this is a fix to a current feature.

Sigurd Nes <sigurdne>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #8134:  password_reminder.diff added by sigurdne (13KiB - application/octet-stream - fix for password reminder with test for changepassword)
file #8133:  test_changepassword.txt added by sigurdne (946B - text/plain - test for acl changepassword at preferences)
file #8132:  test_account_repository.txt added by sigurdne (940B - text/plain - check for account_repository = sql)
file #8161:  password_reminder.diff added by sigurdne (12KiB - application/octet-stream - fix for password reminder)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 7 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-10-04 Caeies StatusNone Done
    Open/ClosedOpen Closed
2005-09-30 sigurdne Attached File- Added password_reminder.diff, #5269
2005-09-30 sigurdne Attached File- Added test_changepassword.txt, #5268
2005-09-30 sigurdne Attached File- Added test_account_repository.txt, #5267
2005-09-30 Caeies Assigned toskwashd Caeies
2005-09-29 sigurdne Attached File- Added password_reminder.diff, #5262

Back to the top

Powered by Savane 3.13-02a9.
Corresponding source code