patchphpGroupWare - Patches: patch #4039, Patch to enable mssql for API...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #4039: Patch to enable mssql for API 0.9.16.005

Submitter:  Sigurd Nes <sigurdne>
Submitted:  Mon 23 May 2005 09:46:01 AM UTC
   
 
Category:  API - phpGWapi Priority:  5 - Normal
Item Group:  0.9.16 (stable) Status:  Done
Privacy:  Public Assigned to:  skwashd
Open/Closed:  Closed

Jump to the original submission

Wed 05 Oct 2005 12:41:00 PM UTC, comment #7: 

Ok,

Commited,

Seems ok for me :)

Regards,

Caeies

Caeies <Caeies>
Group administrator
Sun 02 Oct 2005 01:46:45 PM UTC, comment #6: 

Hi Dave,
Do you have the opportunity to commit this patch?

Regards

Sigurd

Sigurd Nes <sigurdne>
Group Member
Tue 24 May 2005 08:35:25 AM UTC, comment #5: 

Hi Sigurd

I have grabbed it and will commit it in the morning my time (if everything goes to plan).

I am happy with the changes, thanks for that.

Cheers

Dave Hall <skwashd>
Group administrator
Tue 24 May 2005 07:38:18 AM UTC, comment #4: 

added fix for function num_rows()

Sigurd Nes <sigurdne>
Group Member
Tue 24 May 2005 07:22:45 AM UTC, comment #3: 

Hi Dave and others,

Updated:
1) class db extends db_
I finally found why the extended class never worked - it didn’t return values from the function f(). Fixed

2) call mssql_close
I have added this one.

4) GetFKSQL
It is called from _GetTableSQL via _GetFK in class.schema_proc.inc.php
It is now a dummy function.

Regards

Sigurd

Sigurd Nes <sigurdne>
Group Member
Mon 23 May 2005 05:10:19 PM UTC, comment #2: 

Hi Dave,

1) class db extends db_
I couldn't make class.db_mssql.inc.php work as extension to db_ - som I reverted to one that work (with bugfixes - as 'metadata' from the new one).

2) call mssql_close
It might - has never done that in the past.

3)schema_proc
schema_proc has been tested with mssql,mysql and postgresql.

4) GetFKSQL:
I will check this one - it might only apply to HEAD.
GetFKSQL does not return anything - but it is called during setup.

5) class.setup.inc.php:
phpgw_applications.app_id is autoincremented and mssql chokes when trying to insert a value for it. This one is also tested with mssql,mysql and postgresql.

Regards

Sigurd

Sigurd Nes <sigurdne>
Group Member
Mon 23 May 2005 12:52:08 PM UTC, comment #1: 

Hi Sigurd,

I don't have time to apply this before I go away for a week in the sun up North.

Here is some comments based on a quick review:

phpgwapi/inc/class.db_mssql.inc.php
The variables are not needed as it should be "class db extends db_"

souldn't db::disconnect call mssql_close ?

Has the schema_proc changes been tested on any other RDBMS?

schema_proc_mssql, I think GetFKSQL is a new feature and so can't be included into stable(16)

I don't understand why you have made the changes to class.setup.inc.php.  Can you explain?

The rest seems fine to me if anyone else has time to apply the patch.  Please do not apply the sections noted above without checking with me.

Cheers

Dave Hall <skwashd>
Group administrator
Mon 23 May 2005 09:46:01 AM UTC, original submission:  

1) db_addslashes
2) fix for class.db_mssql.inc.php
3) Define columns to take NULL where allowed to
4) fix for inserting values to phpgw_applications during setup

Sigurd Nes <sigurdne>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #8898:  db_mssql_16_008b.diff added by sigurdne (12KiB - application/octet-stream - updated)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 13 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-10-05 Caeies StatusIn Progress Done
    Open/ClosedOpen Closed
2005-10-02 sigurdne Attached File#5170 Removed
2005-10-02 sigurdne Attached File- Added db_mssql_16_008b.diff, #5273
2005-09-14 sigurdne Attached File#4642 Removed
2005-09-14 sigurdne Attached File- Added db_mssql_16_008.diff, #5170
2005-05-24 skwashd StatusNone In Progress
2005-05-24 sigurdne Attached File- Added db_mssql_16_005.diff, #4642
2005-05-24 sigurdne Attached File#4641 Removed
2005-05-24 sigurdne Attached File- Added db_mssql_16_005.diff, #4641
2005-05-24 sigurdne Attached File#4639 Removed
2005-05-23 sigurdne Attached File- Added db_mssql_16_005.diff, #4639
    Carbon-Copy- Added ceb

Back to the top

Powered by Savane 3.13-3230.
Corresponding source code