patchDotGNU Portable.NET - Patches: patch #3582, Anchoring values is miscalculated

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #3582: Anchoring values is miscalculated

Submitter:  Carl-Adam Brengesjo <ptah>
Submitted:  Fri 17 Dec 2004 01:02:24 AM UTC
   
 
Category:  None Priority:  1 - Later
Status:  Invalid Privacy:  Public
Assigned to:  ptah Open/Closed:  Closed

Sun 16 Jan 2005 09:30:06 PM UTC, comment #1: 

My understanding is that Rich333 has correctly solved this issue, which apparently was caused by something completley different than this patch has pointed out, and thus this item should be closed.

Closed as per above Sun 16th Jan 2005.

Carl-Adam Brengesjo <ptah>
Group Member
Fri 17 Dec 2004 01:02:24 AM UTC, original submission:  

After some diggin' into the issues with the anchoring in winforms, reported by Simon Guindon and described in http://dotgnu.org/pipermail/developers/2004-November/012576.html
I was able to narrow it down being caused by the prevParentWidth/prevParentHeight values in a child control is updated with new values without the actual bounds of the control is updated, resulting in the distance between the child bounds and it's parent increases.

I was able to fix this with not allowing not more than one call to InitLayout() (see attached patch), as it was called multiple times and this updating the fields as described above.

However, I'm not so familiar with the layout engine and uncertain how this could affect real-world applications and thus I'm asking for some comments and testing results on this patch so we, hopefully, can elimating creating more bugs :)

Carl-Adam Brengesjo <ptah>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #8191:  AnchoringTest.cs added by ptah (1KiB - text/x-csharp - My testcase.)
file #8190:  anchoring_bug.patch added by ptah (1KiB - text/x-patch - Anchoring cache values patch.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-01-16 ptah StatusNone Invalid
    Open/ClosedOpen Closed
2004-12-17 ptah Attached File- Added AnchoringTest.cs, #3958
2004-12-17 ptah Attached File- Added anchoring_bug.patch, #3957

Back to the top

Powered by Savane 3.13-4b48.
Corresponding source code