patchDotGNU Portable.NET - Patches: patch #3110, unnecessary thread creation when...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #3110: unnecessary thread creation when doing threadpool completion units

Submitter:  David Logan <djlogan>
Submitted:  Mon 31 May 2004 01:42:08 AM UTC
   
 
Category:  None Priority:  3 - Low
Status:  Invalid Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Mon 31 May 2004 01:46:26 PM UTC, comment #3: 

This patch is invalid (as said by the author himself)

Gopal.V <t3rmin4t0r>
Group administrator
Mon 31 May 2004 04:37:39 AM UTC, comment #2: 

DO NOT APPLY THIS PATCH. IT WILL NOT WORK. By limiting thread creation, it is possible that completion units will wait in the wait queue for existing threads to come process work.

Well, it can be true that completion units are dependent upon other completion units, and we don't want the dependents to be in the wait queue waiting for threads that depend on them to execute. Results: Deadlock.

David Logan <djlogan>
Mon 31 May 2004 02:36:19 AM UTC, comment #1: 

Submitting a new patch. The previous one was erroneously submitted with a syntax error in it.

David Logan <djlogan>
Mon 31 May 2004 01:42:08 AM UTC, original submission:  

The routine that added "completion units to do" to the list also checked to see if a new completion thread needed to be started. It was starting a new thread when there were completion units to be done and there were less completion threads than the max available (with no regard to how many currently active completion threads were waiting for work.) I just added a check so that new threads would not be created unless all currently created threads were busy.

David Logan <djlogan>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #7522:  root-040530.threadpool.patch added by djlogan (937B - application/octet-stream - New patch without syntax error)
file #7521:  root-040530.threadpool.patch added by djlogan (1KiB - application/octet-stream - threadpool patch for completion threads)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2004-05-31 t3rmin4t0r StatusNone Invalid
    Open/ClosedOpen Closed
2004-05-31 djlogan Attached File- Added root-040530.threadpool.patch, #3326
2004-05-31 djlogan Attached File- Added root-040530.threadpool.patch, #3325

Back to the top

Powered by Savane 3.13-bb6a.
Corresponding source code