patchphpGroupWare - Patches: patch #209, Sybase port

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #209: Sybase port

Submitter:  Yves Mettier <ymettier>
Submitted:  Wed 03 Apr 2002 09:23:44 AM UTC
   
 
Category:  API - phpGWapi Priority:  5 - Normal
Item Group:  None Status:  None
Privacy:  Public Assigned to:  ceb
Open/Closed:  Closed

Sat 23 Apr 2005 09:07:45 PM UTC, comment #4: 

whats with the sybase support? class.db_sybase has been in 16 cvs but not class.schema_pro_sybase ... ?

Bettina Gille <ceb>
Group administrator
Sat 23 Nov 2002 02:45:11 AM UTC, comment #3: 

mdean said this was ok to go into stable

ymettier thats ok ... i will still go in ... and thanks

Cheers

Dave Hall <skwashd>
Group administrator
Fri 15 Nov 2002 10:15:08 AM UTC, comment #2: 

Hi

My job changed and I will not be able to maintain the patch any more.
But I would be pleased, if another contributor wants to contribute on sybase, if he could start with my work and not from scratch.

Yves

Yves Mettier <ymettier>
Fri 15 Nov 2002 09:57:45 AM UTC, comment #1: 

Hey mdean,

Do you want to look at this one?  I know nothing about Sybase.

Cheers

Dave Hall <skwashd>
Group administrator
Wed 03 Apr 2002 09:23:44 AM UTC, original submission:  

Some comments about my patch:
- Apply it on 0.9.14rc2

- class.schema_proc.inc.php: sybase columns are "NOT NULL" by default. That's why I needed to add the keyword "NULL" if it is not "NOT NULL". It works for sybase, and phpgroupware will not work without it with sybase. I have not tested it with any other database engine (pgsql and mysql).

- sybase.php: this is my main contribution. It is still experimental and should work in some cases and not in others. But without it, 0.9.14rc2 will not work at all with sybase. About the quality of my contribution, I tried to do it as clean as I could. But due to limitations of Sybase, I had to make things that are a little dirty, like analyse requests in order to rewrite them if needed. Doing things clean means that all the database requests should be rewritten in the whole phpgroupware code. I prefer to submit you something small that works and if you think it is necessary, make some bigger changes after that.

- manageheader.php: minor change in order to let users choose sybase. I am not sure it's a good idea to accept this as is because the sybase port is experimental. Maybe you should apply it but comment it?

I'm going on vacation on Apr 9th and I will continue to work on the sybase port when I'm back!

Yves

Yves Mettier <ymettier>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #4306:  patch_item_209.patch added by ymettier (25KiB - text/plain - patch item 209)

 

Depends on the following items: None found

Items that depend on this one: None found

 

CC list is empty

 

There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

 

Follow 4 latest changes.

Date Changed by Updated Field Previous Value => Replaced by
2005-04-23 ceb Open/ClosedOpen Closed
2002-11-23 skwashd Assigned tomdean None
2002-11-15 skwashd Assigned toNone None
2002-09-16 skwashd patch_category_id100

Back to the top

Powered by Savane 3.13-02a9.
Corresponding source code