patchfindutils - Patches: patch #9799, Use GNU_FINDUTILS_FD_LEAK_CHECK...


You are not allowed to post comments on this tracker with your current authentication level.

patch #9799: Use GNU_FINDUTILS_FD_LEAK_CHECK for xargs as well

Submitter:  Pavel Modilaynen <pmod>
Submitted:  Fri 26 Apr 2019 07:14:41 AM UTC
Category:  xargs enhancement Priority:  5 - Normal
Status:  Done Privacy:  Public
Assigned to:  jay Originator Name: 
Open/Closed:  Open Release:  None
Fixed Release:  None

Mon 03 Jun 2019 03:11:33 PM UTC, comment #2: 

Thank you for accepting my first contribution!

Yes, it would be time saver for me and other contributors from Axis Communications. So, would it be possible to have the corporate assignment form for my employer 'Axis Communications' to sign, so all my colleagues are also covered?

Pavel Modilaynen <pmod>
Sun 05 May 2019 05:17:18 PM UTC, comment #1: 

Thank you for this contribution to the GNU project.

Because the bulk of the change primarily moved around some existing code, it meets the criteria set by the GNU project for not requiring a copyright assignment.   Therefore I have been able to apply the change immediately to the Git repository for findutils.

However, the significance of changes is assessed cumulatively, and this means that if you make a further contribution - and I hope you will - the change will require a copyright assignment, even if that second change is itself small.

Therefore it would be a time saver for the future if you could complete the copyright assignment paperwork now, before we need it.   Woud you be willing to do this (i.e. assign the copyright in your future findutils changes to the Free Software Foundation)?

James Youngman <jay>
Group administrator
Fri 26 Apr 2019 07:14:41 AM UTC, original submission:  

Move function that checks environment variable GNU_FINDUTILS_FD_LEAK_CHECK - fd_leak_check_is_enabled() - to lib/fdleak.c. And use it in xargs/xargs.c the same way it is already used in "find" sources.
Update test suite for xargs to have the same behavior as before.

Pavel Modilaynen <pmod>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by jay (Posted a comment)
  • -email is unavailable- added by pmod (Submitted the item)

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.


    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-05-05 jay StatusNone Done
        Assigned toNone jay
    2019-04-26 pmod Attached File- Added 0001-xargs-use-GNU_FINDUTILS_FD_LEAK_CHECK-as-for-find.patch, #46831

    Back to the top

    Powered by Savane 3.13-4b48.
    Corresponding source code