GNU nano - Patches: patch #9704, controldelete and...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9704: controldelete and controlshiftdelete shouldn't be included in nano-tiny
Submitter: | David Lawrence Ramsey <dolorous> | ||
Submitted: | Mon 15 Oct 2018 01:32:29 PM UTC | ||
Priority: | 3 - Low | Status: | Done |
Privacy: | Public | Assigned to: | dolorous |
Open/Closed: | Closed | Release: | None |
Tue 16 Oct 2018 06:35:05 PM UTC, comment #4: |
David Lawrence Ramsey <dolorous> |
Tue 16 Oct 2018 05:28:42 PM UTC, comment #3: Have applied the first, and the second partially: the "Ask..." comments have become too much -- they take more time to read than that they help explain the code. So I have reduced those comments to just one. |
Benno Schulenberg <bens> |
Mon 15 Oct 2018 07:58:30 PM UTC, comment #2: No problem. But I've also noticed another instance of the problem: parse_kbinput() processes it regardless of whether we're in nano-tiny or not, when it should process in only if we're not. The first attached patch fixes this.
|
David Lawrence Ramsey <dolorous> |
Mon 15 Oct 2018 02:54:57 PM UTC, comment #1: Thanks. Applied and pushed, commit 06416e3d. |
Benno Schulenberg <bens> |
Mon 15 Oct 2018 01:32:29 PM UTC, original submission:
Currently, in git e1c8dd0, controldelete and controlshiftdelete are unconditionally defined in global.c. However, they're only set to anything when NANO_TINY isn't defined, so they're never actually used in tiny mode (which does no harm, but is still unnecessary). The attached patch fixes this. |
David Lawrence Ramsey <dolorous> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 7 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2018-11-15 | bens | Open/Closed | Open | Closed | |
2018-10-15 | dolorous | Attached File | - | Added 0001-tweaks-don-t-process-Ctrl-Shift-Delete-in-nano-tiny.patch, #45204 | |
Attached File | - | Added 0002-tweaks-join-one-line-and-add-clarifying-comments.patch, #45205 | |||
2018-10-15 | bens | Priority | 5 - Normal | 3 - Low | |
Status | None | Done | |||
Assigned to | None | dolorous | |||
2018-10-15 | dolorous | Attached File | - | Added 0001-tweaks-don-t-define-controldelete-or-controlshiftdel.patch, #45198 |
Powered by Savane 3.13-02a9.
Corresponding source code
Okay. Thank you.