patchGNU Autoconf Archive - Patches: patch #9674, ax_check_enable_debug: Default to...

 
 

patch #9674: ax_check_enable_debug: Default to "yes", not "no"

Submitter:  Debarshi Ray <debarshiray>
Submitted:  Mon 13 Aug 2018 10:41:10 AM UTC
 
Priority:  5 - Normal Status:  Need Info
Assigned to:  None Open/Closed:  Closed
* Mandatory Fields

Add a New Comment (Rich Markup)
   

Comment Type & Canned Response:
       No canned response available

 

Thu 14 Feb 2019 09:06:13 AM UTC, comment #1: 

Could you please document the new behavior (and your rationale for it) in the macro's documentation to make the behavior more obvious to new users?

Peter Simons <simons>
Project Administrator
Mon 13 Aug 2018 10:41:10 AM UTC, original submission:  

The documentation doesn't state what the default value of the first argument would be, if none is specified. However, reading the code (eg., "empty mean debug yes") and the commit messages (eg., commit 407ddbbc953737a6) it does seem that the first argument is meant to default to "yes", whereas in reality the default is "no".

That is surprising because if someone is using the following snippet, then all builds, release or non-release, default to "no":
    AX_IS_RELEASE([git-directory])
    AX_CHECK_ENABLE_DEBUG()

Why would anybody want that if they explicitly chose to use the
AX_CHECK_ENABLE_DEBUG?

Therefore, it is better to switch the default to "yes".

There's no need to sanitize the enable_debug variable after AC_ARG_ENABLE. It's going to be set to the default value if neither --enable-debug nor --disable-debug are present. If they are present, it's going to be set to "yes" or "no" respectively, or whatever value was explicitly specified.

Debarshi Ray <debarshiray>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:
   
   
Comment:
   

Attached Files
file #44769:  0001-ax_check_enable_debug-Default-to-yes-not-no.patch added by debarshiray (3KiB - text/x-patch - ax_check_enable_debug: Default to "yes", not "no")

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by simons (Posted a comment)
  • -email is unavailable- added by debarshiray (Submitted the item)
  •  

     

     

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2019-04-12 simons Open/ClosedOpen Closed
    2019-02-14 simons StatusNone Need Info
    2018-08-13 debarshiray Attached File- Added 0001-ax_check_enable_debug-Default-to-yes-not-no.patch, #44769

    Back to the top


    Powered by Savane 3.9