patchGNU Autoconf Archive - Patches: patch #9644, AX_JNI_INCLUDE_DIR incorrect...


patch #9644: AX_JNI_INCLUDE_DIR incorrect without host_os defined

Submitter:  Carnë Draug <carandraug>
Submitted:  Sun 27 May 2018 09:42:57 PM UTC
Priority:  5 - Normal Status:  Done
Assigned to:  simons Open/Closed:  Closed
* Mandatory Fields

Add a New Comment (Rich Markup)

Comment Type & Canned Response:
       No canned response available


Tue 29 May 2018 12:29:04 PM UTC, comment #3: 

Applied in a67f384249afcacd78137f274685cfc6d25078f9. Thank you very much.

Peter Simons <simons>
Project Administrator
Tue 29 May 2018 12:02:02 PM UTC, comment #2: 

You're right.  I have attached a modified patch.

(file #44239)

Carnë Draug <carandraug>
Tue 29 May 2018 10:03:14 AM UTC, comment #1: 

I believe the proper way to express that dependency is to add


to the source code. Autoconf actually implements dependencies between macros and it's important to use that mechanism because it matters where the body of that macro is expanded and AC_REQUIRE makes sure this is done correctly.

The section "10.4.1 Prerequisite Macros" in the manual has further details.

Peter Simons <simons>
Project Administrator
Sun 27 May 2018 09:42:57 PM UTC, original submission:  

The macro AX_JNI_INCLUDE_DIR makes use of the variable host_os.  This variable is only set after calling AC_CANONICAL_HOST.  However, AX_JNI_INCLUDE_DIR does not call AC_CANONICAL_HOST and does not document that AC_CANONICAL_HOST should be called first.

At the moment, what happens is that host_os is empty, there's no check for it, and so the returned list of directories is incomplete.

I have patched it by calling AC_CANONICAL_HOST and documenting the implications mentioned on the autoconf manual.

Carnë Draug <carandraug>


(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attach Files:


Depends on the following items: None found

Items that depend on this one: None found


Carbon-Copy List
  • -email is unavailable- added by simons (Posted a comment)
  • -email is unavailable- added by carandraug (Submitted the item)




    Follow 6 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2018-05-29 simons StatusIn Progress Done
        Open/ClosedOpen Closed
    2018-05-29 carandraug Attached File- Added 0001-ax_jni_include_dir.m4-require-AC_CANONICAL_HOST-to-m.patch, #44239
    2018-05-29 simons StatusNone In Progress
        Assigned toNone simons
    2018-05-27 carandraug Attached File- Added 0001-ax_jni_include_dir.m4-call-AC_CANONICAL_HOST-to-make.patch, #44234

    Back to the top

    Powered by Savane 3.9