patchGNUzilla - Patches: patch #9519, Enable JACK audio backend if jackd...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9519: Enable JACK audio backend if jackd is running

Submitter:  Damien Zammit <zamaudio>
Submitted:  Sat 16 Dec 2017 05:05:24 AM UTC
 
Category:  None Priority:  7 - High
Status:  None Privacy:  Public
Assigned to:  None Open/Closed:  Open

Sat 16 Dec 2017 05:09:21 AM UTC, comment #1: 

I spent a lot of time making the backend work, and Mozilla refuses to include the compile flag in default builds because they dont want to support users with an extra audio backend, but the truth is, JACK audio server is superior in GNU/Linux than PulseAudio.

In 55.0a1 I introduced a hidden runtime pref that allows you to select which audio backend to use, but in icecat 52.3.0, the  backend is auto selected with a hardcoded initialisation order: JACK is tried first, then pulse, then alsa in that order (if you build with --enable-jack).  As it stands, it will fall back to pulse backend if jackd is not running.

Damien Zammit <zamaudio>
Sat 16 Dec 2017 05:05:24 AM UTC, original submission:  

diff --git a/makeicecat b/makeicecat
index a91e3a6..039df4b 100644
--- a/makeicecat
+++ b/makeicecat
@@ -207,10 +207,10 @@ EOF
 # Custom settings and features
 ###############################################################################

-# Disable EME
-echo "ac_add_options --disable-eme" >> build/mozconfig.common.override
-echo "ac_add_options --disable-eme" >> build/mozconfig.common
-echo "ac_add_options --disable-eme" >> debian/config/mozconfig.in
+# Disable EME and enable JACK audio (only if jackd is running)
+echo "ac_add_options --disable-eme --enable-jack" >> build/mozconfig.common.override
+echo "ac_add_options --disable-eme --enable-jack" >> build/mozconfig.common
+echo "ac_add_options --disable-eme --enable-jack" >> debian/config/mozconfig.in

 # Disable healthreport
 sed '/mozilla.org\/legal/d' -i toolkit/components/telemetry/healthreport-prefs.js

Damien Zammit <zamaudio>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

No files currently attached

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by zamaudio (Submitted the item)
  • -email is unavailable- added by zamaudio
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

     

     

    Follows 1 latest change.

    Date Changed by Updated Field Previous Value => Replaced by
    2017-12-16 zamaudio Carbon-Copy- Added zamaudio

    Back to the top


    Powered by Savane 3.9