GNU nano - Patches: patch #9434, browser: allow backward/forward...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9434: browser: allow backward/forward researches the same way the help viewer does
Submitter: | David Lawrence Ramsey <dolorous> | ||
Submitted: | Mon 14 Aug 2017 09:38:12 PM UTC | ||
Priority: | 3 - Low | Status: | Done |
Privacy: | Public | Assigned to: | dolorous |
Open/Closed: | Closed | Release: | None |
Jump to the original submission
Sun 20 Aug 2017 07:31:33 AM UTC, comment #10: |
Benno Schulenberg <bens> |
Sat 19 Aug 2017 10:08:30 PM UTC, comment #9: No problem. However, when you inverted the boolean, you didn't do so for the do_fileresearch() calls, so Alt-Up now re-searches forward, while Alt-Down and Alt-W re-search backward.
|
David Lawrence Ramsey <dolorous> |
Sat 19 Aug 2017 08:01:45 PM UTC, comment #8: Pushed to git, 633343de, with an inversion of the boolean. Thanks for the patch. |
Benno Schulenberg <bens> |
Sat 19 Aug 2017 07:26:25 PM UTC, comment #7: Attached new version that builds properly with --enable-tiny --enable-browser (modeled after the similar fix for the help browser), synced with git 5fcda55. |
David Lawrence Ramsey <dolorous> |
Tue 15 Aug 2017 08:58:41 PM UTC, comment #6: Okay. Although if functionality is there, it should still work properly. And good to know on Meta-W.
|
David Lawrence Ramsey <dolorous> |
Tue 15 Aug 2017 07:48:18 PM UTC, comment #5: Inconsistency is in this case a small problem. I can still imagine people searching a help text for something like
|
Benno Schulenberg <bens> |
Tue 15 Aug 2017 04:23:45 PM UTC, comment #4: Addendum: Since comment #1 doesn't actually have the link to the patch, I mean file #41523 specifically. |
David Lawrence Ramsey <dolorous> |
Tue 15 Aug 2017 03:56:47 PM UTC, comment #3: Inconsistency between interfaces is still a problem, though, which is why I did.
|
David Lawrence Ramsey <dolorous> |
Tue 15 Aug 2017 09:54:36 AM UTC, comment #2: Too much code. That is the reason I didn't add Alt+Up/Down to the file browser.
|
Benno Schulenberg <bens> |
Mon 14 Aug 2017 09:56:12 PM UTC, comment #1: Argh. Attached new version, that properly does the search for text within the filenames (in order to find matches) backwards, as well as the search for the filename itself backwards. |
David Lawrence Ramsey <dolorous> |
Mon 14 Aug 2017 09:38:12 PM UTC, original submission:
Currently, as of git 566a2da, the help browser can search backwards and forwards for a previous search string using Alt-Up and Alt-Down (or N and n). However, the file browser cannot do this (and still treats both N and n as keys for forward searches, as the help browser used to, which is inconsistent with the help browser now).
|
David Lawrence Ramsey <dolorous> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 10 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-08-28 | bens | Open/Closed | Open | Closed | |
2017-08-19 | dolorous | Attached File | - | Added 0001-browser-fix-inverted-search-direction-when-calling-d.patch, #41582 | |
2017-08-19 | bens | Status | None | Done | |
Assigned to | None | dolorous | |||
2017-08-19 | dolorous | Attached File | - | Added 0001-browser-allow-backward-forward-searches-with-Alt-Up-.patch, #41580 | |
2017-08-15 | dolorous | Attached File | - | Added 0001-browser-allow-backward-forward-searches-with-Alt-Up-.patch, #41533 | |
2017-08-15 | bens | Summary | browser: allow backward/forward researches the same way the help browser does | browser: allow backward/forward researches the same way the help viewer does | |
2017-08-15 | bens | Priority | 5 - Normal | 3 - Low | |
2017-08-14 | dolorous | Attached File | - | Added 0001-browser-allow-backward-forward-searches-with-Alt-Up-.patch, #41524 | |
2017-08-14 | dolorous | Attached File | - | Added 0001-browser-allow-backward-forward-searches-with-Alt-Up-.patch, #41523 |
Powered by Savane 3.13-02a9.
Corresponding source code
Oops. I had it in my repo, but forgot to git add and commit --amend it. Sorry. Pushed now, a56a881c.