GNU nano - Patches: patch #9414, weeding: remove redundant...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9414: weeding: remove redundant place_the_cursor() call from spotlight()
Submitter: | David Lawrence Ramsey <dolorous> | ||
Submitted: | Sat 22 Jul 2017 05:57:36 AM UTC | ||
Priority: | 3 - Low | Status: | Wont Do |
Privacy: | Public | Assigned to: | None |
Open/Closed: | Closed | Release: | None |
Mon 15 Jun 2020 07:53:47 AM UTC, comment #3: |
Benno Schulenberg <bens> |
Tue 25 Jul 2017 07:44:02 PM UTC, comment #2: Yes, edit_refresh() calls place_the_cursor(), but... I think edit_refresh() should not call place_the_cursor() at all. In most cases that edit_refresh() is called, either 1) the cursor is off, so it is wasteful to place the cursor, or 2) place_the_cursor() is called within ten lines, because it is necessary, or 3) immediately after refreshing the edit window, the prompt bar is redrawn and the cursor is placed there.
|
Benno Schulenberg <bens> |
Sat 22 Jul 2017 04:03:45 PM UTC, comment #1: Check that. In all the places that call spotlight(), edit_refresh() is only called just before the first spotlight() call that turns the highlight on, not before the second one that turns the highlight off. So this should only work for the first call, but in actual practice, it works for both.
|
David Lawrence Ramsey <dolorous> |
Sat 22 Jul 2017 05:57:36 AM UTC, original submission:
All the places that call spotlight() call edit_refresh() just before it, and edit_refresh() calls place_the_cursor() itself. spotlight() thus places the cursor again, in the same spot that edit_refresh() just did; this is unnecessary.
|
David Lawrence Ramsey <dolorous> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 6 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2020-06-15 | bens | Priority | 5 - Normal | 3 - Low | |
Status | None | Wont Do | |||
Open/Closed | Open | Closed | |||
2017-07-22 | dolorous | Attached File | - | Added 0001-weeding-remove-redundant-spotlight-and-place_the_cur.patch, #41289 | |
Attached File | - | Added 0002-weeding-remove-unused-active-parameter-from-spotligh.patch, #41290 | |||
2017-07-22 | dolorous | Attached File | - | Added 0001-weeding-remove-redundant-place_the_cursor-call-from-.patch, #41288 |
Powered by Savane 3.13-f8d8.
Corresponding source code
Obsoleted by other changes.