patchGNU nano - Patches: patch #9273, eliminate the need for extra...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #9273: eliminate the need for extra extract_buffer() parameters

Submitter:  David Lawrence Ramsey <dolorous>
Submitted:  Wed 01 Mar 2017 05:01:29 AM UTC
   
 
Priority:  5 - Normal Status:  Done
Privacy:  Public Assigned to:  None
Open/Closed:  Closed Release:  None

Sun 23 Feb 2020 03:02:55 PM UTC, comment #1: 

This has become superfluous during the reworking of the justify code, beginning in commit 2cdb87ee.

Benno Schulenberg <bens>
Group administrator
Wed 01 Mar 2017 05:01:29 AM UTC, original submission:  

Per the discussions during the revamp of do_insertfile(), there's a simpler way to remove the need to specify the top and bottom of a buffer when throwing it away, without removing the buffer-appending functionality used in the cutting code (which is the place that uses extract_buffer() to most): move throwing away a buffer into a small utility function taking minimal parameters and doing its own trash buffer handling.

The first attached patch against current git does this, creating trash_buffer().  The second cleans up comments in extract_buffer(), moving comments outside of if blocks and explicitly mentioning the buffer-appending functionality, since the latter is no longer used directly outside of extract_buffer().

David Lawrence Ramsey <dolorous>
Group Member

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by bens (Posted a comment)
  • -email is unavailable- added by dolorous (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 4 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2020-02-23 bens StatusNone Done
        Open/ClosedOpen Closed
    2017-03-01 dolorous Attached File- Added 0001-tweaks-move-extracting-and-throwing-away-a-buffer-in.patch, #39859
        Attached File- Added 0002-tweaks-improve-comments-in-extract_buffer.patch, #39860

    Back to the top

    Powered by Savane 3.13-f8d8.
    Corresponding source code