Gnash - The GNU Flash player - Patches: patch #9234, Patch for adding automated...
You are not allowed to post comments on this tracker with your current authentication level.
patch #9234: Patch for adding automated slash-colon path checks on `GetVariable()` plugin function
Submitter: | Nutchanon Wetchasit <nachanon> | ||
Submitted: | Mon 23 Jan 2017 04:35:56 PM UTC | ||
Category: | testsuite | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | strk | Open/Closed: | Closed |
Jump to the original submission
Mon 30 Jan 2017 07:44:19 AM UTC, comment #12: |
Sandro Santilli <strk> |
Sun 29 Jan 2017 10:20:27 AM UTC, comment #11: The unrelated `make check` error mentioned in comment 10 is now reported as bug #50174.
|
Nutchanon Wetchasit <nachanon> |
Sat 28 Jan 2017 05:26:55 PM UTC, comment #10: As of Gnash 0.8.11dev git 36028f4, the newly-added GetVariable() test works as expected. This entry could now be marked as Done. (I don't have a privilege to do this on my own, though)
|
Nutchanon Wetchasit <nachanon> |
Sat 28 Jan 2017 07:10:56 AM UTC, comment #9: Thanks, 0006_add-slashcolon-getvariable-test-v3.patch pushed as commit 36028f40cc8fee39d411e13284f2d7334e84b9cc after amending to drop trailing blanks (git diff --check; git show --check)
|
Sandro Santilli <strk> |
Fri 27 Jan 2017 10:16:59 AM UTC, comment #8: See the attached `0006_add-slashcolon-getvariable-test-v3.patch`
|
Nutchanon Wetchasit <nachanon> |
Spam posted by karlab | |
Wed 25 Jan 2017 10:57:41 AM UTC, comment #6: Thanks, I can confirm things work now.
|
Sandro Santilli <strk> |
Wed 25 Jan 2017 10:35:13 AM UTC, comment #5: Side note (for the record):
|
Nutchanon Wetchasit <nachanon> |
Wed 25 Jan 2017 10:30:29 AM UTC, comment #4: For the errors I mentioned about my patch:
|
Nutchanon Wetchasit <nachanon> |
Wed 25 Jan 2017 10:14:35 AM UTC, comment #3: It is important to note that this test checks interaction
|
Nutchanon Wetchasit <nachanon> |
Wed 25 Jan 2017 10:03:50 AM UTC, comment #2: There might be errors in my patch, but that should not prevent the relevant
|
Nutchanon Wetchasit <nachanon> |
Tue 24 Jan 2017 05:50:24 PM UTC, comment #1: I'm trying to run the .swf with the proprietary player to check it's correctness but failing, did you succeed ? Can you help with that ? I'd expect traces in output with "flashplayerdebug" but not getting any. Maybe I didn't build it correctly (make submoviegetvar.swf) |
Sandro Santilli <strk> |
Mon 23 Jan 2017 04:35:56 PM UTC, original submission:
See the attached `0006_add-slashcolon-getvariable-test.patch`.
|
Nutchanon Wetchasit <nachanon> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 11 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2017-01-30 | strk | Status | Ready For Test | Done | |
Open/Closed | Open | Closed | |||
2017-01-28 | strk | Status | Need Info | Ready For Test | |
Assigned to | None | strk | |||
2017-01-27 | nachanon | Attached File | - | Added 0006_add-slashcolon-getvariable-test-v3.patch, #39569 | |
2017-01-25 | nachanon | Attached File | - | Added 0006_add-slashcolon-getvariable-test-v2.patch, #39556 | |
Attached File | - | Added submoviegetvar-v2.zip, #39557 | |||
2017-01-25 | nachanon | Attached File | - | Added submoviegetvar.html, #39555 | |
2017-01-25 | nachanon | Attached File | - | Added submoviegetvar.swf, #39554 | |
2017-01-24 | strk | Status | None | Need Info | |
2017-01-23 | nachanon | Attached File | - | Added 0006_add-slashcolon-getvariable-test.patch, #39541 |
Powered by Savane 3.13-02a9.
Corresponding source code
Thank you. I agree it was good to open bug #50174