Gnash - The GNU Flash player - Patches: patch #8993, Patches to fix problems when...
You are not allowed to post comments on this tracker with your current authentication level.
patch #8993: Patches to fix problems when `--disable-media` configure option was used
Submitter: | Nutchanon Wetchasit <nachanon> | ||
Submitted: | Sat 07 May 2016 02:59:36 AM UTC | ||
Category: | sound | Priority: | 5 - Normal |
Status: | Done | Privacy: | Public |
Assigned to: | strk | Open/Closed: | Closed |
Jump to the original submission
Wed 11 May 2016 06:24:16 PM UTC, comment #14: |
Sandro Santilli <strk> |
Wed 11 May 2016 04:17:40 PM UTC, comment #13: On current Gnash git version, build errors and crashes are now fixed. Thanks.
|
Nutchanon Wetchasit <nachanon> |
Wed 11 May 2016 01:10:21 PM UTC, comment #12: I actually like to keep debugging output fully instructive.
|
Sandro Santilli <strk> |
Tue 10 May 2016 05:59:28 PM UTC, comment #11: The new version of patch 1 adds return value fixup, changes log message display, and drops libgnashmedia MediaParser operator move.
|
Nutchanon Wetchasit <nachanon> |
Tue 10 May 2016 05:53:23 PM UTC, comment #10: @strk:
|
Nutchanon Wetchasit <nachanon> |
Tue 10 May 2016 05:01:52 PM UTC, comment #9: Nah, too much work, let's just let it go. After all we're not really expecting anything except gnash to use those libraries.
|
Sandro Santilli <strk> |
Tue 10 May 2016 03:09:21 PM UTC, comment #8: An alternative solution that I could come up with right now is changing the problematic log messages to show just codec number instead of codec name, by casting the `media::videoCodecType format` enum to a generic `int` when `USE_MEDIA` macro is absent.
|
Nutchanon Wetchasit <nachanon> |
Tue 10 May 2016 03:04:08 PM UTC, comment #7: From the code causing link error, they are both SWF parser's logging code; when `log_parse()` tries to convert `media::audioCodecType` to string, it invokes operator `ostream << media::audioCodecType`, which is only implemented in `libgnashmedia.so`.
|
Nutchanon Wetchasit <nachanon> |
Tue 10 May 2016 02:52:03 PM UTC, comment #6: For the compiler warning, thanks for pointing that out; definitely a good idea to include it in the fix since it is related to `USE_MEDIA` code exclusion. Maybe I didn't stumble on it because it didn't cause an immediate build problem.
|
Nutchanon Wetchasit <nachanon> |
Mon 09 May 2016 12:07:04 PM UTC, comment #5: Another issue is this warning:
|
Sandro Santilli <strk> |
Mon 09 May 2016 10:47:53 AM UTC, comment #4: The move of output operator for audioCodecType from .cpp to .h file would change ABI, is that necessary ? (in 0001_fix-disable-media-compile-link-failure.patch)
|
Sandro Santilli <strk> |
Mon 09 May 2016 03:05:30 AM UTC, comment #3: I have made a variant of patch 2 which fixes the crash on Gnash 0.8.10. (Patch 1 is not required for 0.8.10, since it builds without failure) It was tested on the same configuration as comment 2.
|
Nutchanon Wetchasit <nachanon> |
Sat 07 May 2016 03:11:20 AM UTC, comment #2: The posted patches are tested with following scenarios:
|
Nutchanon Wetchasit <nachanon> |
Sat 07 May 2016 03:09:35 AM UTC, comment #1: Patch 2 of 2:
|
Nutchanon Wetchasit <nachanon> |
Sat 07 May 2016 02:59:36 AM UTC, original submission:
Patch 1 of 2:
|
Nutchanon Wetchasit <nachanon> |
Depends on the following items: None found
Items that depend on this one: None found
There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.
Follow 8 latest changes.
Date | Changed by | Updated Field | Previous Value | => | Replaced by |
---|---|---|---|---|---|
2016-05-11 | strk | Status | Ready For Test | Done | |
Open/Closed | Open | Closed | |||
2016-05-11 | strk | Status | None | Ready For Test | |
Assigned to | None | strk | |||
2016-05-10 | nachanon | Attached File | - | Added 0001_fix-disable-media-compile-link-failure-v2.patch, #37120 | |
2016-05-09 | nachanon | Attached File | - | Added 0002_refuse-invoking-nonexistent-media-handler-0.8.10.patch, #37106 | |
2016-05-07 | nachanon | Attached File | - | Added 0002_refuse-invoking-nonexistent-media-handler.patch, #37094 | |
2016-05-07 | nachanon | Attached File | - | Added 0001_fix-disable-media-compile-link-failure.patch, #37093 |
Powered by Savane 3.13-02a9.
Corresponding source code
Thanks for confirming (and for the patches!)