patchGnash - The GNU Flash player - Patches: patch #8938, Patch to add a missing bracket in...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8938: Patch to add a missing bracket in front of debug log messages

Submitter:  Nutchanon Wetchasit <nachanon>
Submitted:  Wed 09 Mar 2016 10:42:47 AM UTC
   
 
Category:  None Priority:  4
Status:  Done Privacy:  Public
Assigned to:  None Open/Closed:  Closed

Wed 09 Mar 2016 12:35:44 PM UTC, comment #1: 

I think it was intentional, anyway, pushed :)
commit a72afa572ede07393cead17211a0ab61210394e4

Sandro Santilli <strk>
Group Member
Wed 09 Mar 2016 10:42:47 AM UTC, original submission:  

This is kind of a cosmetic issue, and is trivial to fix.

When I looked at current Gnash's debug output, e.g.:

20044:1] 678 TRACE: Hello World!


It bugs me a lot that what exactly first two number, colon, and
a dangling bracket printed in front of log message are for [1].
It first glance, I thought it was some kind of broken ANSI escape code.

After I digged around Gnash's libbase code, I found that the numbers are
actually process ID and thread ID, which makes sense; but the open bracket was
conspicuously missing.

So I wrote a patch to fix the missing bracket, see the attached
`0001_add-missing-bracket-to-debug-log.patch`.

After applied the patch, you'll see that Gnash's debug output now look like:

[3916:1] 131 TRACE: Hello World!


Gnash: 0.8.11dev (patched against git 8b33692 7-Mar-2016)
System: Debian GNU/Linux 7.0 Wheezy i386

[1] Side note: I have searched around current Gnash user manual and developer
reference, and found nothing that mention process/thread ID part of the log
message. (For the timestamp, developer reference only briefly mentioned it as
a part of `LogFile::setStamp()` description)

Nutchanon Wetchasit <nachanon>

 

(Note: upload size limit is set to 16384 kB, after insertion of the required escape characters.)

Attached Files
file #36577:  0001_add-missing-bracket-to-debug-log.patch added by nachanon (532B - text/x-diff - Patch for adding the missing open bracket to log messages)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -email is unavailable- added by strk (Posted a comment)
  • -email is unavailable- added by nachanon (Submitted the item)
  •  

    There are 0 votes so far. Votes easily highlight which items people would like to see resolved in priority, independently of the priority of the item set by tracker managers.

     

    Follow 3 latest changes.

    Date Changed by Updated Field Previous Value => Replaced by
    2016-03-09 strk StatusNone Done
        Open/ClosedOpen Closed
    2016-03-09 nachanon Attached File- Added 0001_add-missing-bracket-to-debug-log.patch, #36577

    Back to the top

    Powered by Savane 3.13-aa77.
    Corresponding source code