patchGnash - The GNU Flash player - Patches: patch #8914, Patches to improve exception...

 
 

You are not allowed to post comments on this tracker with your current authentication level.

patch #8914: Patches to improve exception handling in Gnash's ExternalInterface callback

Submitted by:  Nutchanon Wetchasit <nachanon>
Submitted on:  Sat 20 Feb 2016 06:31:10 AM UTC  
 
Category: corePriority: 5 - Normal
Status: Ready For TestPrivacy: Public
Assigned to: Sandro Santilli <strk>Open/Closed: Open

Mon 22 Feb 2016 09:50:58 AM UTC, comment #2:

Patch 1 pushed as commit 54a08c95d6ab2a6b06564ef58e8f93055fb8ef87
Patch 2 pushed as commit c12c3cf104a095cff9791cdb3cee8bbf4853d5e0

Sandro Santilli <strk>
Project MemberIn charge of this item.
Sat 20 Feb 2016 06:36:45 AM UTC, comment #1:

Current Gnash (player)'s ExternalInterface callback handler employs an
in-band error code detection to log callback failure on debug channel.
This caused an error message to be logged when the callback legitimately
returned "Error" or "SecurityError" string.

Although this does not affect outcome of the operation (return value is
already sent to the container), it causes confusion and pollutes debug log.

Patch 2 of 2:
See the attached `0006_externalinterface-drop-error-string-check-msg.patch`.

This patch removes the check, so that normal "Error" or "SecurityError" string
return value from ExternalInterface callback is not mistakenly flagged as
a callback failure, fixing bug #47004.

Gnash: 0.8.11dev (patched against git 051aa9c 15-Feb-2016) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy

(file #36407)

Nutchanon Wetchasit <nachanon>
Sat 20 Feb 2016 06:31:10 AM UTC, original submission:

This is a follow-up to patch #8909 (ExternalInterface in-band error fix).

Current Gnash (player) have a special-case return value check on
ExternalInterface callback invocation. This caused legitimate `null` return
value from the callback to be changed to an in-band error signal
indistinguishable from normal "Error" string return value.

Patch 1 of 2:
See the attached `0005_externalinterface-callback-drop-inband-error-generation.patch`.

This patch removes the check, so that `null` return value from the callback
could be correctly passed to host container, partially fixing bug #47004.

Gnash: 0.8.11dev (patched against git 051aa9c 15-Feb-2016) NPAPI
Browser: Iceweasel 10.0.12 (debian)
System: Debian GNU/Linux 7.0 Wheezy

Nutchanon Wetchasit <nachanon>

 

Attached Files
file #36407:  0006_externalinterface-drop-error-string-check-msg.patch added by nachanon (958B - text/x-diff - Patch to remove in-band error flagging from ExternalInterface callback handler)
file #36406:  0005_externalinterface-callback-drop-inband-error-generation.patch added by nachanon (868B - text/x-diff - Patch to drop in-band error code generation on `null` return value of ExternalInterface callback)

 

Depends on the following items: None found

Items that depend on this one: None found

 

Carbon-Copy List
  • -unavailable- added by strk (Posted a comment)
  • -unavailable- added by nachanon (Submitted the item)
  •  

    Do you think this task is very important?
    If so, you can click here to add your encouragement to it.
    This task has 0 encouragements so far.

    Only logged-in users can vote.

     

    Please enter the title of George Orwell's famous dystopian book (it's a date):

     

     

    Follow 4 latest changes.

    Date Changed By Updated Field Previous Value => Replaced By
    Mon 22 Feb 2016 09:50:58 AM UTCstrkStatusNone=>Ready For Test
      Assigned toNone=>strk
    Sat 20 Feb 2016 06:36:45 AM UTCnachanonAttached File-=>Added 0006_externalinterface-drop-error-string-check-msg.patch, #36407
    Sat 20 Feb 2016 06:31:10 AM UTCnachanonAttached File-=>Added 0005_externalinterface-callback-drop-inband-error-generation.patch, #36406

    Back to the top


    Powered by Savane 3.1-cleanup1